search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
434 stars 159 forks source link

Stop support for old acceptance tests #10259

Closed ScharfViktor closed 4 months ago

ScharfViktor commented 9 months ago

2 years ago, we stopped implement old acceptance tests and started using e2e with playwright. Now we want to:

Steps:

ScharfViktor commented 9 months ago

CC @saw-jan

amrita-shrestha commented 7 months ago

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not https://github.com/owncloud/web/pull/10481. Otherwise, my PR will be stuck for a long time.

ScharfViktor commented 7 months ago

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not #10481. Otherwise, my PR will be stuck for a long time.

Sorry, how this task is related to #10481 ?

saw-jan commented 7 months ago

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not #10481. Otherwise, my PR will be stuck for a long time.

Let's run /journeys/kindergarten.feature with the keycloak for now, then we can go on to include more tests. CC @amrita-shrestha @ScharfViktor

amrita-shrestha commented 7 months ago

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not #10481. Otherwise, my PR will be stuck for a long time.

Sorry, how this task is related to #10481 ?

If we add some scenario/step on space.feature and journey then maybe that step needs refactoring to work on ocis-keycloak. I am not saying to check all scenario/step. Just step/scenario which falls under keycloak tests(currently journey/space.feature).

PrajwolAmatya commented 6 months ago

I have listed the tests that has been already covered in E2E and tests that needs to be added in E2E.

Tests that has been covered

E2E tests that needs to be added

~- Files details~ ~- view different areas in app-sidebar for file and folder~ ~- [ ] Preview~ ~- [ ] preview different files (.png file) @Salipa-Gurung (https://github.com/owncloud/web/pull/10670)~ ~- [x] pubilc user preview files: https://github.com/owncloud/web/pull/10565~

~- sorting resources~ ~- share autocompletion of recipient user/group~ ~- check for sharing details of items inside a shared folder~ ~- check for sharing indicator~ ~- check for public link indicator~ ~- [ ] edit password of public link and public user refresh the public link page~ ~- [ ] update content of file~

CC. @ScharfViktor @saw-jan

Updated according to comment: https://github.com/owncloud/web/issues/10259#issuecomment-2009826676

Note:- All TODOs tasks have been added to the main description of this issue.

saw-jan commented 6 months ago

pubilc user preview files: https://github.com/owncloud/web/pull/10565

the PR is just a port. we already have the tests in master

kulmann commented 6 months ago

E2E tests that needs to be added

I'd like to continue to only have happy path tests in e2e. That being said, some of the test scenarios you mentioned are not needed for e2e and I'd like to not have them anymore.

  • breadcrumb
    • breadcrumb navigation on normal folders

Yes, good one.

  • breadbrumb navigation on folders with quotes and special characters

Not needed.

  • Files details
    • view different areas in app-sidebar for file and folder

What exactly do you have in mind? I'd expect this mostly to be tested via unit tests. Some e2e test coverage makes sense of course, but please be more specific in what you want to test.

  • Preview
    • preview different files

One .png file is sufficient.

Yes 👍

Sorting resources is not something I would test at all in e2e. Only in unit tests.

  • share autocompletion of recipient user/group

I believe we have that somewhat covered in sharing related tests. no additional test needed.

  • check for sharing details of items inside a shared folder

sufficient as a unit test, no e2e needed.

  • check for sharing indicator

sufficient as a unit test, no e2e needed.

  • check for public link indicator

sufficient as a unit test, no e2e needed.

  • edit password of public link and public user refresh the public link page

Yes, good one.

  • update content of file

Yes, good one.

PrajwolAmatya commented 6 months ago

@kulmann Thank you for the suggestion. :+1: I will update the E2E test list and work accordingly.

kulmann commented 6 months ago

  • breadcrumb

    • breadcrumb navigation on normal folders

Yes, good one.

  • breadbrumb navigation on folders with quotes and special characters

Not needed.

I'd like to come back to this one again. I'd love to have a "navigation"-scenario in the e2e tests:

That would bring certainty especially for representation and handling of weird chars in the URL.

Do we have something like this? Or something that could be extended into this behaviour? I don't want all these cases tested individually (file list with simple folder names, file list with complex folder names, breadcrumb with simple folder names, breadcrumb with complex folder names), but really in one scenario.

I know that the common pattern for acceptance tests is to write short scenarios. For our e2e test suite I see much more value in chains of actions and test patterns that semantically belong together, so that the test setup time doesn't kill us.

What do you think @PrajwolAmatya ?

PrajwolAmatya commented 6 months ago

@kulmann Yes, I think we can check for navigation through breadcrumb for variety of folder names within a single scenario.

amrita-shrestha commented 5 months ago

@saw-jan @Salipa-Gurung @PrajwolAmatya can we close this issue https://github.com/owncloud/web/issues/7264 or we going to let it open?

saw-jan commented 4 months ago

@ScharfViktor Let's close this one. The only thing remaining is to cleanup in ocis drone config but that should be done along with the web bump to ocis

ScharfViktor commented 4 months ago

@ScharfViktor Let's close this one. The only thing remaining is to cleanup in ocis drone config but that should be done along with the web bump to ocis

Yes, I close it, but before I wanted to clean up ocis CI

ScharfViktor commented 4 months ago

closed as completed