owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
443 stars 157 forks source link

draw.io diagram editor can not be closed #10439

Closed fschrempf closed 9 months ago

fschrempf commented 9 months ago

Describe the bug

Using the drawi.io diagram editor in the web UI, closing the editor from within the editor itself is not possible.

Steps to reproduce

  1. Run oCIS 4.0.5 as per documentation
  2. Enable the draw.io app by editing the config.json
  3. Open a *.drawio file in the web UI
  4. Use the Exit Button to close the editor

Expected behavior

The diagram editor is closed.

Actual behavior

The diagram editor stays open and the browser console gives a warning: Scripts may close only the windows that were opened by them.

Setup

config.json

[...]
  "external_apps": [
    {
      "id": "draw-io",
      "path": "web-app-draw-io",
      "config": {
        "url": "https://embed.diagrams.net",
        "theme": "minimal"
      }
    }
  ]
AlexAndBear commented 9 months ago

Thanks for your report, we've fixed this in the upcoming version ocis-5.0.0

RupertBarrow commented 9 months ago

Hi @JanAckermann , could you point me to the fix in the source code, please, or the issue/PR which fixes it ? Thanks