Open jvillafanez opened 4 months ago
Good point 🤔 For the lock information shown in the details panel I would actually like to have both. owner
for the application owning the lock, and if present also the ownername
(as in the username).
@jvillafanez could you please make sure that the ownername
is being added to the propfind response as well? We can make it show only if present, that's not an issue.
For the application name, we'll fix that. But could you provide a human readable display name of the application in that field? Because I don't want to show com.github.owncloud.collaboration.Collabora
in the UI. I want to show Collabora
instead.
cc @tbsbdr
Maybe @micbar can double-check what information I should provide...
As far as I know, the lock is hold by the app (Collabora in this case). Including a user would show something like userA@idp via com.github.owncloud.collaboration.Collabora
, but if userB is also editing the file and then userA leaves, then having that lock information might be confusing because it seems userA is holding the lock although he isn't editing. In addition, I'm not sure how it will behave because userB might attempt to refresh the lock (which I'm not sure if it will cause issues).
For the ownername
, as said, the information comes from the opaque. There are several things to consider:
This is why I'm not sure if it's a good idea to use the ownername
. I think we'd be relying on the code not changing (at least that piece), but there is nothing preventing it.
For the application name, we'll fix that. But could you provide a human readable display name of the application in that field? Because I don't want to show com.github.owncloud.collaboration.Collabora in the UI. I want to show Collabora instead.
This is also something to discuss.
Right now, the appname comes from the configured COLLABORATION_APP_LOCKNAME
, which is com.github.owncloud.collaboration
by default. Since people won't likely change the variable, I appended the COLLABORATION_APP_NAME
so we could have several WOPI apps deployed at the same time.
I think we can remove the COLLABORATION_APP_LOCKNAME
from the configuration, and just use the COLLABORATION_APP_NAME
also for the locks. That would show the name we want and also allow parallel deployment of WOPI apps.
Thanks for the context, that's really helpful! I agree, showing the ownername
(as in: username) is a bad idea then. So let's not do that.
For the owner
prop: What about keeping it like is and instead writing the COLLABORATION_APP_NAME
into a new field to be consumed by clients for displaying the info? Propfind field something like owner-displayname
or alike?
Please let us check that we are in line with the rfc. The locking info is part of the WebDAV RFC where we should be compatible.
Describe the bug
The lock information shown for the file details is empty if the file is locked with the new collaboration service
Steps to reproduce
Expected behavior
The details should show a "Locked by" with some information
Actual behavior
The "Locked by" is empty
Setup
Please describe how you started the server and provide a list of relevant environment variables or configuration files.
```console OCIS_XXX=somevalue OCIS_YYY=somevalue PROXY_XXX=somevalue ```
Additional context
The locked file is the "Untitled 3.docx" file. Propfind below.
I'd expect the
<d:owner>com.github.owncloud.collaboration.Collabora</d:owner>
info to be shown as "locked by".As far as I've seen in the code, the
oc:ownername
property is used instead, which is missing in the propfind. The property comes from opaque information (https://github.com/cs3org/reva/blob/edge/internal/http/services/owncloud/ocdav/propfind/propfind.go#L1767-L1771), so I'm not sure if we should use that because it seems to be considered as optional information that might not be present.