fix: use gettext config for l10n-write

kulmann commented 1 month ago

Description

After https://github.com/owncloud/web/pull/10389 was merged, the translation sync CI job committed translations.json files without any translations, only english was included.

This PR here includes:

use gettext.config.cjs file for writing translations.json files
remove en from list of locales in gettext.config.cjs, because english is the source language. Throws errors during l10n-write makefile target if still included.
cleanup of the translations Makefile in packages/web-runtime/l10n, there was weird special handling for the l10n folder in the web-runtime package and there were unused variables which I have removed now.

How Has This Been Tested?

Ran all the steps locally, everything looking good now.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests
[ ] Documentation
[ ] Maintenance (e.g. dependency updates or tooling)

update-docs[bot] commented 1 month ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

kulmann commented 1 month ago

CI is red because translations are empty for anything except English and there are two e2e tests that check on translated content. I'll force-merge and trigger the translation-sync drone job to get up to date translations again.

owncloud / web