[check-console-errors] Console error e2e fixes

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale

https://owncloud.dev/clients/web/

GNU Affero General Public License v3.0

421 stars 157 forks source link

[check-console-errors] Console error e2e fixes #11024

Closed AlexAndBear closed 1 month ago

AlexAndBear commented 1 month ago

Description

Related Issue

Fixes https://github.com/owncloud/web/issues/11011

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests
[ ] Documentation
[ ] Maintenance (e.g. dependency updates or tooling)

Open tasks:

[ ] ...

update-docs[bot] commented 1 month ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

ScharfViktor commented 1 month ago

@AlexAndBear I changed title. If we want to check CI we need -> [check-console-errors] in the title

AlexAndBear commented 1 month ago

Green now, I guess we can enable it. There is still one error coming trough:


  Scenario: crud operation to public link for space # tests/e2e/cucumber/features/spaces/publicLink.feature:119
[UNCAUGHT EXCEPTION] "TypeError: Cannot convert undefined or null to object"
    ✖ failed
      Error: expect(received).not.toBeDefined()

      Received: [TypeError: Cannot convert undefined or null to object]
          at Proxy.<anonymous> (/var/www/owncloud/web/node_modules/.pnpm/playwright@1.39.0/node_modules/playwright/lib/matchers/expect.js:173:37)
          at Page.<anonymous> (/var/www/owncloud/web/tests/e2e/support/environment/actor/actor.ts:30:31)

But looks like this test is successful in the re-run and is not web related, worth looking into @ScharfViktor

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ScharfViktor commented 1 month ago

But looks like this test is successful in the re-run and is not web related, worth looking into @ScharfViktor

done, all tests are green)). we didn't close the page to the public. we closed it at the end if the test was failed (so after a retry, the test would turn green)