Add file picker mode - Githubissues

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale

https://owncloud.dev/clients/web/

GNU Affero General Public License v3.0

434 stars 159 forks source link

Add file picker mode #11074

Closed AlexAndBear closed 3 months ago

AlexAndBear commented 3 months ago

Description

for testing add ?embed=true&embed-target=file&embed-extensions=txt

Related Issue

Fixes https://github.com/owncloud/web/issues/11052

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests
[ ] Documentation
[ ] Maintenance (e.g. dependency updates or tooling)

Open tasks:

[ ] ...

update-docs[bot] commented 3 months ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

AlexAndBear commented 3 months ago

File click action will be done in the Open file PR

AlexAndBear commented 3 months ago

Check boxes are visible in target location as well. Can you check if this is on purpose (since not shown in usual files list)? If no, I can disable on both targets

JammingBen commented 3 months ago

Check boxes are visible in target location as well. Can you check if this is on purpose (since not shown in usual files list)? If no, I can disable on both targets

Then this is a bug for the location target as well 😬

AlexAndBear commented 3 months ago

Check boxes are visible in target location as well. Can you check if this is on purpose (since not shown in usual files list)? If no, I can disable on both targets

Then this is a bug for the location target as well 😬

Then I'll just resovle it (:

AlexAndBear commented 3 months ago

Check boxes are visible in target location as well. Can you check if this is on purpose (since not shown in usual files list)? If no, I can disable on both targets

Then this is a bug for the location target as well 😬

Fixed. I will add the docs later, when I implement the open file action part and I get the idea how all of this will work together :D

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud