search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
420 stars 156 forks source link

Initial page loading spinner never hides in some scenarios #11083

Closed JammingBen closed 2 weeks ago

JammingBen commented 2 weeks ago

Describe the bug

The initial page loading spinner never hides in scenarios where we don't load all apps. This is due to the fact that the spinner only gets removed via a callback after all apps have been loaded.

Steps to reproduce

  1. Go to https://host.docker.internal:9200/access-denied
  2. Enjoy the endless loading state

Expected behavior

The loading spinner eventually disappears.

Actual behavior

It stay forever on such pages.

This is a regression from https://github.com/owncloud/web/pull/11054.

kulmann commented 2 weeks ago

I can't reproduce it with current master 🙈 neither mit vite nor with a production build.

JammingBen commented 2 weeks ago

Now I can't either... but it's a timing issue. The loading spinner appears after 0.5 seconds. Meaning if the page loads faster than that, everything is fine. But if it's slower, then the loading spinner will appear and never go away.