Closed AlexAndBear closed 1 day ago
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.
TBD:
Nice progress! I noticed some things:
- if I have the right sidebar open in the main window, the embed mode in the modal starts with visible right sidebar. I'd like the embed mode to always start with closed sidebar
Since the sidebar will be controlled by localStorage, this is a little hard to achieve, maybe in a followup
- paddings are somehow off in the right sidebar. E.g. the
x
button for closing the right sidebar floats out of the sidebar, into the blue border on the right.
Not reproducible, could you check again and upload a screenshot?
- visually it makes a quite heavy impression, that the embed mode has the dark blue frame and is placed in an otherwise white modal.
@tbsbdr remarked this as well, and proposed a blue modal, @kulmann is against that, can you please propose something you both are fine with?
Functionality already works flawlessly 💯
:)
Only a few tiny remarks, otherwise awesome stuff!
Did you try what happens if token renewal takes places during the modal being open? I noticed the iFrame spawns another web worker for the token renewal... I hope it doesn't have a negative effect 🙈
I didn't 🙈
Changelog is missing
@kulmann Unfortunately I can't easily, we use the dispatchModal function here to display the modal, and our FilePickerModal component will be just the rendered content. I only have the possibility to adjust CSS but injecting elements would end up in spaghetti code.
Another possibility could be: Add the cancel button to the bottom like we have it in other file picker modes and just disable the header and top of the modal via CSS
Another possibility could be: Add the cancel button to the bottom like we have it in other file picker modes and just disable the header and top of the modal via CSS
Yes, sounds good. But as a followup please. :-)
Issues
3 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Another possibility could be: Add the cancel button to the bottom like we have it in other file picker modes and just disable the header and top of the modal via CSS
Yes, sounds good. But as a followup please. :-)
I'll merge this and open a follow up pr, so we can show it tomorrow
Toodalo!
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: