search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
418 stars 157 forks source link

FR: Show detailed information about a share #11101

Open AlexAndBear opened 1 week ago

AlexAndBear commented 1 week ago

As a user I want to know what I can do within a share (permissions). Especially if I am navigating in a secure view share

kulmann commented 1 week ago

As far as I can see the backend doesn't expose this information, right? If that's correct, could you create an ocis issue for this? If it does I can take care of the web story.

AlexAndBear commented 1 week ago

I think this information is in the GraphSharePermissions that are accessible trough sharing Ng ? Or am I wrong ?

JammingBen commented 3 days ago

The .../permissions endpoint for a resource returns all the graph permissions the user is allowed to share the resource with. You want to have that information for an existing share though, right?

I guess you can always query the permission that holds all necessary information. Or maybe the DAV permissions are sufficient? They should indicate what the user is allowed to do and what not.

AlexAndBear commented 3 days ago

The .../permissions endpoint for a resource returns all the graph permissions the user is allowed to share the resource with. You want to have that information for an existing share though, right?

I guess you can always query the permission that holds all necessary information. Or maybe the DAV permissions are sufficient? They should indicate what the user is allowed to do and what not.

Yep about existing share. From what I remember of my implementation for secure view. The graph permissions are already persisted in the shared resource object

JammingBen commented 2 days ago

The graph permissions are already persisted in the shared resource object

Correct 👍 The terminology is a bit confusing here: a "share" in our terms is a "permission" in Graph terms. A "permission" in our terms is an "action" in Graph terms.

Still, the DAV permissions give away all necessary information, no? They are a bit more "digestable" than the Graph permissions.

kulmann commented 2 days ago

They are a bit more "digestable" than the Graph permissions.

That's a sad thing to say about a new API 😢

JammingBen commented 2 days ago

Hmm not sure if I would agree. From a UI perspective - yes, definitely! But from a server perspective, having them so granular might actually be a good thing. IMO they are just not designed to be visualized in some UI.