search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
437 stars 156 forks source link

Tiles view tile sizes broken #11757

Closed kulmann closed 2 days ago

kulmann commented 2 days ago

Describe the bug

Tiles view tile sizes are broken, resizing the tiles also only resizes the icons, nothing else.

Steps to reproduce

  1. Upload some different files, some images and some without preview
  2. Switch to grid view

Expected behavior

Our usual beautiful tiles view.

Actual behavior

This abomination:

Screenshot 2024-10-11 at 08 23 48
kulmann commented 2 days ago

Since the last rolling release was still working I bisected with the current master HEAD as good and the release of 10.3.0 as good commit. Result of git bisect:

cd90140ac17f87bb82bfa9a51a020af8b3f69669 is the first bad commit
commit cd90140ac17f87bb82bfa9a51a020af8b3f69669
Author: Jannik Stehle <jannik.stehle@kiteworks.com>
Date:   Wed Oct 9 08:17:05 2024 +0200

    fix(a11y): tiles view sort select

    Transforms the select dropdown in the tiles view to a select input to be a11y compliant.

 .../src/components/FilesList/ResourceTiles.vue     |  62 ++++-------
 .../components/FilesList/ResourceTiles.spec.ts     | 114 ++++++++++-----------
 .../__snapshots__/ResourceTiles.spec.ts.snap       |  38 +++----
 3 files changed, 94 insertions(+), 120 deletions(-)

So it broke in https://github.com/owncloud/web/pull/11747