Collaborators tweaks after review

[pmaier1]

Moved to https://github.com/owncloud/enterprise/blob/master/product/oc10/index.md#collaborators

Tasks

[butonic]

Linking this here because the university of augsburg implmentet sharing on top of NFSv4 ACLs back in 2016. On slide 33 they present their mapping of oc CRUDS permissions to ACLs.

[pmaier1]

Feedback from first testing

• [x] Opening left sidebar moves the whole screen (including e.g., the account indicator on the top right) => feels strange => intended? => https://github.com/owncloud/phoenix/issues/1904

• [x] Logout/Exit does not log out => works for me /Vincent

• ~The currently logged in user's name should be shown as "You" (e.g. as Owner)~ => https://github.com/owncloud/phoenix/issues/2062

• File list

  • [x] Clicking on a file does not select it but highlight => intended? => yes, solved with @LukasHirt
  • [x] Views are missing
  • [x] Shared with you
  • [x] Shared with others
  • [x] Shared by link => https://github.com/owncloud/phoenix/issues/2058 deferred

• Considerations UX fheidecke https://github.com/owncloud/phoenix/issues/1640 => very valid, IMO

• [x] Pending Shares does not work and can break Phoenix => https://github.com/owncloud/phoenix/issues/1667

• Adding/modifying collaborators

  • [x] Too less visible separation, focus and guidance between the elements => https://github.com/owncloud/phoenix/issues/1908 https://github.com/owncloud/phoenix/issues/1907
  • [x] Roles: Need better explanation text: https://github.com/owncloud/phoenix/issues/2059
  • [x] Roles: Explanation text, when already selected, should appear in the same edit box of the picker's
  • [x] No way to undo changes instead of saving them
  • [x] Bug: Switching from "custom role" to another role does only reload the permission checkboxes if you save
  • [x] Custom role: Making changes after saving does not enable the save button again; can also happen when changing from "custom role" to another role
  • [x] Single file: "Custom role" shows "can change" instead of "Edit" https://github.com/owncloud/phoenix/issues/1961
  • [x] You can't find users by their user name if a display name is set
  • [x] You can't find users by their mail address
  • [x] "Extra field to display in autocomplete results" is not respected
  • [x] Selected collaborators for adding should also have avatars and better styling for the delete icon
  • [x] Federated sharing does not work => https://github.com/owncloud/phoenix/issues/2050 deferred
  • [x] Guest sharing does not work => https://github.com/owncloud/phoenix/issues/2057 deferred
  • [x] Role switcher should have a default => actually the default single perms are configurable in the backend but as we don't have a mapping to roles there yet I would take "Viewer" as default for now
  • [x] If you edit a collaborator and set the same content than before, it shows "Save" (e.g. have a collaborator as "Viewer", click on the dropdown and choose "Viewer" again)
  • [x] If you edit a collaborator, make a change, then switch to another tab (e.g. "Links") and switch back to "Collaborators" => locks the UI

• Autocomplete

  • [x] Existing collaborators are still shown => can even (try to) add existing collaborators
  • [x] Avatars are not shown
  • [x] Additional information (e.g. "Extra field to display in autocomplete results") is not shown

• Collaborator list

  • [x] Reshare indicator appears even if it's not a reshare
  • [x] "Custom role" is shown for "Editor/Viewer + can share"
  • [x] Do we need a count for Collaborators AND users AND groups??
  • [x] Trash bin icon to remove a collaborator maybe not appropriate?: https://github.com/owncloud/phoenix/issues/2059
  • [x] Closing an "edit" dialog without saving may cause human mistakes => obsolete
  • [x] (+) symbol to expand collaborators is not intuitive: https://github.com/owncloud/phoenix/issues/1908 => obsolete
  • [x] If reshare is not possible (e.g., disabled or no permission) users can still add collaborators but it fails
  • [x] When the list takes some time to load, there's no spinner/indicator
  • [x] Avatars are dummies
  • [x] A reshare recipient can't recognize the resharer

• File list

  • [x] The user can't conduct any actions for the current folder (e.g. add collaborators): https://github.com/owncloud/phoenix/issues/2061 deferred

• [x] Collaborators can't recognize their role/permissions => Show role + explanation text somewhere

[PVince81]

Found in ee3b72eb083085296d0bde9da2f40a049d585d63 today:

• [x] in "Shared with me" and "Shared with others", assuming we want the same design like in OC 10:
  • clicking on a folder must redirect to the actual folder in the "All files" view
  • a trash icon must be available to "unshare from self"
  • actions for accept/deny for pending shares (to verify)

=> raised as https://github.com/owncloud/phoenix/issues/2077

[LukasHirt]

actions for accept/deny for pending shares (to verify)

Should be implemented. Needs double-check.

[PVince81]

I've raised tickets for all the items. @pmaier1 you might want to review them and provide more information there in case it's not clear enough.

[PVince81]

• [x] Add a margin bottom to "You don't have permission..."

[PVince81]

• [x] Collaborator autocomplete must clear text field after selecting

[kulmann]

• [x] In the "new collaborator" panel, selecting a user share excludes a group share with the same name from the list of candidates. Need to check for shareWith AND shareType, not only shareWith
• [x] fix hr tags / separators in collaborator forms (maybe remove some, fix overflow)