search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
447 stars 157 forks source link

Sidebar is overlapping content of file picker ("Save as" / "Open") #11875

Open JammingBen opened 3 weeks ago

JammingBen commented 3 weeks ago

Describe the bug

The right sidebar is overlapping the content of the file picker ("Save as" / "Open" actions) if opened.

Steps to reproduce

  1. Open a text file
  2. Open the right sidebar
  3. From the context menu, click "Save as" or "Open"

Expected behavior

The sidebar should not be visible in the file picker.

Actual behavior

It's visible and overlapping all the content.

AlexAndBear commented 2 weeks ago

Now, that I fixed the modal width is this issue still relevant ?

JammingBen commented 2 weeks ago

I'd say yes, because the problem still becomes a thing on smaller screens and on mobile.

AlexAndBear commented 2 weeks ago

Got you. As of now I can't think of a proper solution as the iframe and the window do share the same local storage

JammingBen commented 2 weeks ago

True, hmmm. All solutions I can think of are somewhat hacky... Maybe just ignore the sidebar storage setting in embed mode and use a local state in the useSideBar composable instead? Would be sufficient for an embedded Web I guess.

AlexAndBear commented 2 weeks ago

I am not 100% sure about that, @kulmann and me already talked about it in the reviews and decided to leave it as it is. I suggest to give it p4, now we have the width fixed and decide on a solution later

JammingBen commented 2 weeks ago

Fine be me!