owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
444 stars 157 forks source link

Accessibility #252

Closed DeepDiver1975 closed 5 years ago

DeepDiver1975 commented 6 years ago

We need to keep a close eye on accessibility.

tempelgogo commented 6 years ago

A lot of the available Accessibility Features are controlled via additional attributes at the nodes, like ARIA Attributes. We can easily bind them dynamically with additional data via Vue.

In my opinion, the biggest trouble is to ensure that there are no untagged elements, respecting our (yet not existent) "Accessibility Guidelines".

So we have to use some validator & static code analyzer tools.

Do we prefer to fully integrate the validator toolsuite into our pipeline - like the standalone accessibility validator a11y - or is it possible to use external API's ? Because there are much tools out there, which are uploading the entire codebase to an external API to verify the Accessibility of the generated code. Although our code is open, i personally don't like this approach.

Our recommendation is to use conventional node compatible test tools, like Mocha or Jest, and enrich them with appropriate policy rule sets. Because we already use selenium, a extension plugin (like axe) for that may be a wise choice.

But as already mentioned by the axe tool, keep always in mind:

Please note that only 20% to 50% of all accessibility issues can automatically be detected. Manual testing is always required. For more information see: https://dequeuniversity.com/curriculum/courses/testingmethods

DeepDiver1975 commented 6 years ago

@michaelstingl regarding Accessibility Guidelines - do we have any plans for this?

I'm all-in for tools which can be executed by devs locally. Feel free to give axe a try ...

michaelstingl commented 6 years ago

Maybe there's something we can learn from Wordpress.org: https://rianrietveld.com/2018/10/09/i-have-resigned-the-wordpress-accessibility-team/ (good links in the post: handbook, testing etc.)

I'm in touch with folks in the Nuremberg community, but they're all busy with https://nuernberg.digital/festival/ at the moment.

michaelstingl commented 6 years ago

Also https://docs.gitlab.com/ee/development/new_fe_guide/development/accessibility.html (Example of another, I'd say even more complex web application)

DeepDiver1975 commented 5 years ago

we have axe as part of CI - should be enough for now ....