search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
429 stars 160 forks source link

[Technical Debt] use signed urls for all media fetching #3846

Open kulmann opened 4 years ago

kulmann commented 4 years ago

There are some locations in code where we actually don't use signed urls for fetching media as of now.

In all cases, the mixin mediaSource.js is used, so it is fairly easy to change. But with the current implementation of signed urls in oc10 and ocis, all requests will fetch a new signing key first. Because of this, all requests are actually firing two requests, which slows down loading thumbnails in the files list a lot.

Solution would be, to properly cache the signing key. Requires both oc10 and ocis to expose the token TTL, so that the client can cache the signing key. Then we could try again to switch over to loading everything from a signed url instead of as a blob.

fschade commented 3 years ago

some points mentioned where fixed by https://github.com/owncloud/web/pull/5194. We should revisit this issue and discuss further improvements