Open tbsbdr opened 3 years ago
I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.
I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.
Should be possible (according to https://kabbouchi.github.io/tippyjs-v4-docs/all-options/, search for "role" on this page) in OcTooltip.js
in the design system, yet haven't tried it myself
@pascalwengerter oh thx didnt see that
aria-labelledby moved to correct element in modal in ODS commit https://github.com/owncloud/owncloud-design-system/pull/1530/commits/2def9143d1fdeb7a180fb4829ad123ec506c5526
page title for location picker is fixed in https://github.com/owncloud/web/pull/5512/commits/dac2db7dd0204486a8ff3b84737c0e510b8b7fa7 but needs german translations (will do that in bulk later)
We won't fix the Note: the anchor links (in this case "Zum Hauptinhalt springen") should be implemented as links and not as buttons.
and keep it as a button instead, since it's no violation and would need major refactoring.
General notes
Status: rather fulfilled
Status: partly fulfilled
Page 1 (Alle Dateien) When copying or moving an element (Folder or file) a new page is opened. On opening (because of using aria-live="polite“) the text "Zur Seite files- location-picker navigiert" is read by screenreaders. This text contains an English variable and is not informative. A better solution would be to remove aria-live="polite" and move the keyboard focus with tabindex="-1" on the h1-heading on page load. See general notes
Page 2 (Mit anderen geteilten Dateien) See general notes
Page 3 (Gelöschte Dateien) See general notes