owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
437 stars 157 forks source link

[a11y] 9.4.1.2 - Name, role, value available #5397

Open tbsbdr opened 3 years ago

tbsbdr commented 3 years ago

Status: rather fulfilled

Status: partly fulfilled

lookacat commented 3 years ago

I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.

pascalwengerter commented 3 years ago

I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.

Should be possible (according to https://kabbouchi.github.io/tippyjs-v4-docs/all-options/, search for "role" on this page) in OcTooltip.js in the design system, yet haven't tried it myself

lookacat commented 3 years ago

@pascalwengerter oh thx didnt see that

kulmann commented 3 years ago

role from tippy removed in https://github.com/owncloud/owncloud-design-system/pull/1530/commits/2ef8eaa69d85f54144e4c2a566b088e8588c7066

kulmann commented 3 years ago

aria-labelledby moved to correct element in modal in ODS commit https://github.com/owncloud/owncloud-design-system/pull/1530/commits/2def9143d1fdeb7a180fb4829ad123ec506c5526

kulmann commented 3 years ago

page title for location picker is fixed in https://github.com/owncloud/web/pull/5512/commits/dac2db7dd0204486a8ff3b84737c0e510b8b7fa7 but needs german translations (will do that in bulk later)

kulmann commented 3 years ago

We won't fix the Note: the anchor links (in this case "Zum Hauptinhalt springen") should be implemented as links and not as buttons. and keep it as a button instead, since it's no violation and would need major refactoring.