search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
443 stars 157 forks source link

No right click menu nor action on non app-providder items #6002

Closed diocas closed 2 years ago

diocas commented 3 years ago

After the latest update, if I right click or click on a file whose extension doesn't have an app provider app associated, nothing happens. In the console it complains on packages/web-app-files/src/mixins/fileActions.js:179 that app_providers is undefined.

Steps to reproduce

  1. Pull the latest master
  2. Right click on a file
dschmidt commented 2 years ago

Cannot reproduce. Is this still an issue? What's the filename you are using? Screenshot_20211211_114445

diocas commented 2 years ago

Just built from latest master and I still see the issue. Do you have the app provider enabled and configured with apps? It needs to return something other than an empty list, otherwise it works.

You can see my fix to understand the issue: if the app provider list is completely empty, the function that returns the handlers returns empty early. If it's not empty, then it filters it to get the apps that handle that particular mimetype, which will fail later if the filtered list is empty.

pascalwengerter commented 2 years ago

Cannot reproduce. Is this still an issue? What's the filename you are using? Screenshot_20211211_114445

@dschmidt did you use app-provider related services a la https://owncloud.dev/ocis/deployment/ocis_wopi/? Perhaps the problem is not visible if you don't start WOPI+Collabora/OnlyOffice/Codimd/*