Release 5.5.0

[fschade]

Waiting for

• https://github.com/owncloud/web/pull/6749
• https://github.com/owncloud/web/pull/6202
• https://github.com/owncloud/web/pull/6593
• https://github.com/owncloud/web/pull/6834 (needed to unblock translation sync), needs https://github.com/owncloud/easygettext/pull/1 merged, tagged and bumped here
• https://github.com/owncloud/web/pull/6820
• https://github.com/owncloud/web/pull/6848
• https://github.com/owncloud/web/pull/7067
• https://github.com/owncloud/web/pull/6994
• https://github.com/owncloud/web/pull/7053
• check if we can make use of drag&drop for move in PublicFiles.vue, spaces/Project.vue, shares/SharedResource.vue as well https://github.com/owncloud/web/pull/7126
• fix finding file names for copy/move conflict handling when choosing keep both (only works on first iteration) https://github.com/owncloud/web/pull/7119
• https://github.com/owncloud/web/pull/7128
• https://github.com/owncloud/web/pull/7131
• https://github.com/owncloud/web/pull/7127

Release checklist

• [x] pin release issue @fschade
• [x] release & bump ODS if needed
• [ ] release & bump SDK if needed
• [x] prepare release rc
  • [x] create a branch release-5.5.0 @kulmann
  • [x] update the version in packages/web-integration-oc10/appinfo/info.xml @kulmann
  • [x] update the version in package.json @kulmann
  • [x] update the version in sonar-project.properties @kulmann
  • [x] move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @kulmann
  • [x] update the ocis commit id in .drone.env to the most recent one from ocis master (let's see how it goes) @kulmann
  • [x] commit, push and create draft PR for this branch @kulmann
• [x] create pre release tag v5.5.0-rc.1 from the release branch @kulmann
• [x] smoke test
  • [x] against oCIS @ScharfViktor
  • [x] against oc10 as sidecar deployment @fschade
  • [ ] against oc10 as app installation
  • [ ] against oCIS wopi example / app provider
  • [ ] ~against oc10 with OnlyOffice app installed~ skipped
• [x] if needed, fix issues or write down known issues
• [x] update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD
• [x] Make sure translations are up to date by updating them in Transifex and restarting translation sync job https://drone.owncloud.com/owncloud/translation-sync/ @pascalwengerter
• repeat above steps if a new rc is needed
• [x] Run translations sync job once again
• [x] go to the releases section and click Draft a new Release. Use v5.5.0 as a tag (the v prefix is important) and 5.5.0 as name and publish it
• [x] ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
• [x] merge release branch back to master (CI must be green)

[lookacat]

Smoke Testing agains ocis:

SmokeTest against ocis

branch: v5.5.0-rc.1

Case 1: admin share folder(with file) to marie:

Admin:

• [x] upload big fil 10gb - feels great
• [ ] upload folder with 2000 small files. ! about 4 errors are thrown, after reload page becomes unresponsive for minutes
• [x] Check pagination, count items per page - 100 files
• [x] upload folder(drag folder) "folder_to_share" with file.pdf
• [x] share folder "folder_to_share" to marie with edit right

Marie:

• [x] accept "folder_to_share" (Header/Table looks weird and far down)
• [x] rename "folder_to_share"
• [x] upload new file "file.txt" to "folder_to_share" (admin see new file)
• [x] open image
• [x] rename image.jpg (use rigth click) (admin see that file changed name)

Admin:

• [x] add new file.jpeg to "folder_to_share"
• [x] add file format drawio (marie can open in Draw.io and can edit)
• [x] move file.pdf to root "personal" (marie can not see file.pdf)
• [/] add new "file.txt" create new version. (use drag and drop) (!!!Drag and Drop is broken, no effekt on hover)
• [ ] open txt file in markdown-editor. Change and save. (Can't open it in markdown)

Marie:

• [x] 🚫 can download both versions (!error 501)
• [x] restore old version

Admin:

• [x] change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

• [x] decline folder (removed from shares folder)
• [x] accept again

Admin:

• [x] delete folder "folder_to_share" (removed from shared with me, removed from Marie)

Case 2: admin share file to marie:

Admin:

• [x] upload file.jpeg
• [x] share file.jpeg to marie with rigth viewer (use main menu. find marie by email marie@example.org)

Marie:

• [x] accept file (marie can open/download/copy file but cannot delete/move/rename)
• [x] copy file to "/"
• [x] open file in Mediaviewer
• [x] download file

Admin:

• [x] share "file.txt" with edit right with "radium-lovers" group

Marie:

• [x] marie can see file while she is member of the group
• [x] rename file (🚫admin don't see)
• [x] change content of the file (can see new version)

Admin:

• [x] unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:

• [x] create folder "for upload"
• [x] add link with name "to_upload" with role "Uploader" with pass and expiration date
• [x] open link (can only upload)
• [x] upload file (admin can see new file)
• [x] change share "for upload" from "Uploader" to "edit"
• [x] admin add new file to "for upload"
• [x] refresh link (file exist)
• [x] admin change pass (refresh link has to type new pass)

Case 4: admin create link to file

Admin:

• [x] create file png
• [x] add link with main menu
• [x] open link(can open, download, see) in the incognito tab
• [x] change link, add pass
• [x] refresh page (input pass)
• [x] delete link
• [x] refresh page (resource not found)
• [x] delete file
• [x] restore
• [x] delete
• [x] Empty trash

Case 5: space story:

Admin gives to richard role "Space Admin":

Richard: 🚫 - [ ] create space - cannot create space with "Space Admin" permissions

Admin:

• [x] create space 🚫 - [ ] add space image - doesn't work/ PROPFIND 404. Image is not displayed
• [x] add subtitle "for test"
• [x] edit description
• [x] try to upload file (more 1 Gb) - (507- Insufficient Storage)
• [x] increase quota to 5Gb and try again
• [x] delete file
• [x] add member Marie with edit role
• [x] add member Einstein with viewer role

Marie:

• [x] can see space without accepting
• [x] change image and description
• [x] can upload file/folder and create file and folder
• [x] cannot create resource sharing and space sharing
• [x] can see deleted files and can restore files from trash
• [x] cannot disable space

Einstein:

• [x] can see space without accepting
• [x] cannot change image and description
• [x] cannot upload file/folder and create file and folder
• [x] cannot create resource sharing and space sharing
• [x] can see deleted files and cannot restore files from trash
• [x] cannot disable space

Admin change Einstein role to manager:

Einstein:

• [x] can see space without accepting
• [x] can change image and description
• [x] can upload file/folder and create file and folder
• [x] can create resource sharing and space sharing
• [x] can see deleted files and can restore files from trash
• [x] can change admins role and delete share
• [x] can disable and delete space

Case 6: user managment

Admin:

• [x] create new account "tom"
• [ ] change language
• [ ] admin blocks and deletes user "tom" - not impemented

Findings:

• https://github.com/owncloud/web/issues/6858
• Setting space image is broken- back end issue: owncloud/web#6874
• https://github.com/owncloud/web/issues/6866

[ScharfViktor]

start ocis via docker-compose doesn't work: web_ocis exited with code 1

jwt_secret has not been set properly in your config for ocis. Make sure your /etc/ocis config contains the proper values (e.g. by running ocis init or setting it manually in the config/corresponding environment variable).

we need add ocis init

[kulmann]

start ocis via docker-compose doesn't work: web_ocis exited with code 1

jwt_secret has not been set properly in your config for ocis. Make sure your /etc/ocis config contains the proper values (e.g. by running ocis init or setting it manually in the config/corresponding environment variable).

we need add ocis init

fixed in https://github.com/owncloud/web/pull/6860 I have rebased this branch already

[ScharfViktor]

fixed in #6860 I have rebased this branch already

I've already tested. It works. thanks)

[kulmann]

Smoke test v5.5.0-rc.10 (in spe, built it from release branch) against oc10 app

• :heavy_check_mark: as gunter - upload arch/mips folder from linux kernel (1801 files)

  • via drag and drop folder upload works
  • via folder upload button works

• :heavy_check_mark: as gunter - share the folder to alice as viewer

• :heavy_check_mark: as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• :heavy_check_mark: as alice - try do delete file from shared folder

  • individual delete action not visible, good
  • batch delete action not visible, good
  • context menu action not visible, good

• :heavy_check_mark: as alice - try to add file

  • not possible (which is expected)
  • drag & drop upload handle it with an error (which is good)

• ❌ as alice - copy 16 folders from share to home (via location picker)

  • no visible feedback that it's in progress
  • UI still weirdly usable, ended up in an active upload drop zone. Needed a page reload to be usable again.

• :heavy_check_mark: as alice - copy 16 folders from share to home (via keyboard action)

• :heavy_check_mark: as gunter - add new file to share

• :heavy_check_mark: as alice - receive new file in existing share

• :heavy_check_mark: as gunter - unshare folder from shared with others

• :heavy_check_mark: as alice - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• :heavy_check_mark: as gunter - share folder with alice again, but as editor

  • setting and removing an expiration date work as expected, good

• :heavy_check_mark: as alice - rename a file

  • via right sidebar, works, good
  • via context menu, works, good

• :heavy_check_mark: as gunter - add file

• :heavy_check_mark: as alice - delete file

  • via right sidebar, works, good
  • via context menu, works, good
  • via batch action, works, good

• :heavy_check_mark: as alice - create public link on any folder

• :heavy_check_mark: as alice delete file and recover it

• :heavy_check_mark: as alice create version of textfile

• :heavy_check_mark: as alice view version history of text file

• :heavy_check_mark: as alice download newest version of text file

• :heavy_check_mark: download older version of text file

• :heavy_check_mark: restore older version of text file

  • no visible feedback about the success
  • preview is not updated

• :heavy_check_mark: as alice - upload avatar in classic UI

  • see own avatar in top bar (far right)
  • login as gunter, having a share with alice
    • shared with others page loads
    • avatar of alice is not shown (bad)

• :heavy_check_mark: as alice, move a file into subfolder via drag and drop

• :heavy_check_mark: as alice, move multiple files & folders into subfolder via drag and drop

• :heavy_check_mark: as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

New findings

• shared with others page doesn't show avatars anymore

Resolved issues

• upload issues regarding slow/laggy web ui and non-sticky progress bar are resolved
• sharing issue where sharing during in-progress uploads was not possible is resolved
• trying to upload a file in a read only share doesn't open the file in a new tab anymore but shows an upload error instead
• UX for copy/move is good with keyboard actions. location picker issues remain.

[ScharfViktor]

Smoke web agains ocis

branch: v5.5.0-rc.10

Case 1: admin share folder(with file) to marie:

Admin:

• [x] upload big file 10gb (Show details, pause upload, resume upload work correct)
• [x] upload folder with 803 small images.
• [x] Check pagination, count items per page. Have a bug https://github.com/owncloud/web/issues/6768
• [x] upload folder(drag folder) "folder_to_share" with file.pdf
• [x] share folder "folder_to_share" to marie with edit right

Marie:

• [x] accept "folder_to_share"
• [x] rename "folder_to_share" - cannot rename folder in new implementation
• [x] upload new file "file.txt" to "folder_to_share" (admin see new file)
• [x] open pdf file
• [x] rename file.pdf (use rigth click) (admin see that file changed name)

Admin:

• [x] add new file.jpeg to "folder_to_share"
• [x] move file.pdf to root "personal" (marie can not see file.pdf)
• [x] add new "file.txt" create new version. (use drag and drop)
• [x] open txt file in markdown-editor. Change and save.

Marie:

• [x] can download both versions
• [x] restore old version

Admin:

• [x] change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

• [x] decline folder (removed from shares folder)
• [x] accept again

Admin:

• [x] delete folder "folder_to_share" (removed from shared with me, removed from Marie)

Case 2: admin share file to marie:

Admin:

• [x] upload file.jpeg
• [x] share file.jpeg to marie with rigth viewer (use main menu. find marie by email marie@example.org)

Marie:

• [x] accept file (marie can open/download/copy file but cannot delete/move/rename)
• [x] open file in Mediaviewer
• [x] download file

Admin:

• [x] share share "file.txt" with edit right

Marie:

• [x] rename file - cannot rename in new implementation
• [x] change content of the file (can see new version)

Admin:

• [x] unshare "file.jpeg" (marie cannot see "file.jpeg")

Case 3: admin create public links to folder

Admin:

• [x] create folder "for upload"
• [x] add link with name "to_upload" with role "Uploader" with pass and expiration date
• [x] open link (can only upload)
• [x] upload file (admin can see new file)
• [x] change share "for upload" from "Uploader" to "edit"
• [x] admin add new file to folder "for upload"
• [x] refresh link (file exist)
• [x] admin change pass (refresh link has to type new pass)

Case 4: admin create link to file

Admin:

• [x] create file png
• [x] add link with main menu
• [x] open link(can open, download, see) in the incognito tab
• [x] change link, add pass
• [x] refresh page (input pass)
• [x] delete link
• [x] refresh page (resource not found)
• [x] delete file
• [x] restore
• [x] delete
• [x] Empty trash

Case 5: space story:

Katherine:

• [x] create space
• [x] add space image
• [x] add subtitle "for test"
• [x] edit description
• [x] try to upload file (more 1 Gb)
• [x] increase quota to 5Gb and try again
• [x] delete file
• [x] add member Marie with edit role
• [x] add member Einstein with viewer role

Marie:

• [x] can see space without accepting
• [x] change image and description
• [x] can upload file/folder and create file and folder
• [x] cannot create resource sharing and space sharing
• [x] can see deleted files and can restore files from trash
• [x] cannot disable space

Einstein:

• [x] can see space without accepting
• [x] cannot change image and description
• [x] cannot upload file/folder and create file and folder
• [x] cannot create resource sharing and space sharing
• [x] can see deleted files and cannot restore files from trash
• [x] cannot disable space

Katherine change Einstein role to manager - is not working yet. It relates to re-sharing

Case 6: create new user via accounts:

Admin (test via api):

• [x] create new account "tom" use graph Api
• [x] create new group
• [x] share folder with group
• [x] change language
• [x] delete users

Remarks:

• preview of the file is gone
• creating public link: https://github.com/owncloud/web/issues/7149
• share space with manager role does't work