owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
427 stars 159 forks source link

Copy/move only works with personal space #6892

Closed kulmann closed 1 year ago

kulmann commented 2 years ago

With the share jail being merged the LocationPicker view, which let's you select a target location for a copy or move action, only lists a single webdav endpoint, namely the personal space. As each accepted share and any project space have their own webdav endpoint we need to come up with a solution to list alternative target locations. This is a regression and needs to be tackled as soon as possible.

Steps to reproduce

  1. Visit personal space
  2. Select "Copy" or "Move" in the right-click context menu of any file or folder

Expected behaviour

Get presented with all available target locations and be able to navigate into any of their subfolders

Actual behaviour

Only see the content of the personal space

Things to consider

This is not just a matter of listing all available webdav endpoints in the LocationPicker view. It requires further UX adaoptions in the web UI. As a cross-storage-move in reality is a combination of copy and delete backend-side it is in fact a slow operation. Probably important to make this transparent to the user. One solution could be that our until now separated Copy and Move actions in the web UI get merged into one Copy or move action. The LocationPicker view could then have multiple submit buttons, depending on what operation is available in the target location, e.g. Move, Copy or Copy and delete.

First step

Needs a clear UI/UX concept. Nothing to implement, yet.

Followup tasks when this is done

cc @tbsbdr @butonic

kulmann commented 2 years ago

This has been mitigated via keyboard actions which are available on all relevant views now (Personal, shares/SharedResource, spaces/Project and PublicFiles). This also enables cross-webdav-endpoint copy / move in the web ui.

tbsbdr commented 2 years ago

This also enables cross-webdav-endpoint copy / move in the web ui.

awesome 🤩

tbsbdr commented 2 years ago

paste here button should be dismissable, eg via a drop menu or split button with "X"

tbsbdr commented 2 years ago

@lookacat for a first step I'd propose to not show the "Paste here" button next to the upload button but only have the "paste here" option in the context menu (MVP: breadcrumb 3-dots)

I would like to test if users really need the "Paste here" button nextx to "Upload" (my bet: yes) but lets test it.

would that procedure be ok for you?

lookacat commented 2 years ago

ok

tbsbdr commented 2 years ago
tbsbdr commented 1 year ago

Proposals for the dialog.

What title is best?

I favour option 2 "Short question" as it's the shortest for "Only Title Reading Users" and as it is not a negative (defect-orientated) wording but more positive, solution orientated.

Negative:

image

Short question:

image

Long question:

image

The target for "Learn more" does not exist yet. Context-Helper could also do the job.

Any objections or additions against / to option 2 @lookacat @kulmann ?

kulmann commented 1 year ago

thank you for thinking this through @tbsbdr !

I'm also in favour of option 2 (same reasoning, simple, focused on solution, reading the title gives the most important information).

For the description I'd like to suggest that we find a more generic text which works for single- and multi-file move attempts. Something like Moving files from one space to another is not possible. Do you want to copy instead?. What do you think?

And yes, context-helper would be good for Learn more.

tbsbdr commented 1 year ago

yep, fine 👍 so lets go with:

image

lookacat commented 1 year ago

will look into it

kulmann commented 1 year ago

@lookacat thank you 😇

@tbsbdr could you provide a mockup for the contextual helper?

tbsbdr commented 1 year ago

Contextual helper proposal:

figma link

Shares, links, and versions of this item are not copied. Tags will be copied. The copied item will be visible to everyone who can see “Budget-Folder 2023”.

Helper copy cross space