Closed SwikritiT closed 2 years ago
As per the initial investigation, the tests fail with following ui screen:
TO NOTE:
All above mentioned tests have same issue
Looks suspiciously like https://github.com/owncloud/ocis/issues/3749
I also think that's the reason behind failing tests.
I get this ocis log whenever that happens:
{
"level":"error",
"service":"storage-users",
"pkg":"rgrpc",
"traceid":"00000000000000000000000000000000",
"error":"remove /home/sawjan/.ocis/storage/users/spacetypes/personal/7b425492-6b0f-43f3-9ded-247e279ac93f.flock: no such file or directory",
"node":"marshaling error: json: unsupported value: encountered a cycle via *node.Node",
"time":"2022-05-10T14:25:39+05:45",
"message":"could not convert to storage space"
}
And there are plenty of such errors in the failing pipeline
@pascalwengerter So, what can be done here?
@pascalwengerter So, what can be done here?
Nothing on the web/qa side. Skipping the tests would be inacceptable, as well as endless retries/page reloads. We need a fix in oCIS and then an oCIS commit ID bump. Let's keep this issue open
oCIS lock issue: https://github.com/owncloud/ocis/issues/3757
test failure in nightly probably because of this:
Tests look pretty stable with the latest oCIS. The culprit issue in oCIS has been fixed (https://github.com/owncloud/ocis/issues/3757). Bumping is on the way (https://github.com/owncloud/web/pull/6946). CI should be stable after bumping.
IMO, this issue can be closed alongside the bump PR merge.
Closing via https://github.com/owncloud/web/pull/6946, thanks for the efforts!
failed again on last nightly build: https://drone.owncloud.com/owncloud/web/25589/54/15
@smokeTest @ocisSmokeTest Scenario: move a file into a folder # features/webUIMoveFilesFolders/moveFiles.feature:20 - Connecting to selenium on port 4444... ℹ Connected to selenium on port 4444 (247ms). Using: chrome (94.0.4606.61) on Linux platform. Given user "Alice" has been created with default attributes and without skeleton files in the server And user "Alice" has created folder "simple-folder" in the server And user "Alice" has uploaded file "lorem.txt" to "lorem.txt" in the server Given user "Alice" has logged in using the webUI √ Element was visible after 766 milliseconds. √ Element was not present after 161 milliseconds. √ Element <#files-view> was visible after 580 milliseconds. And user "Alice" has uploaded file "data.tar.gz" to "data.tar.gz" in the server And user "Alice" has uploaded file "strängé filename (duplicate #2 &).txt" to "strängé filename (duplicate #2 &).txt" in the server And user "Alice" has created folder "strängé नेपाली folder empty" in the server And the user has reloaded the current page of the webUI When the user moves file "lorem.txt" into folder "simple-folder" using the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='lorem.txt' or @data-test-resource-path='/lorem.txt')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 26 milliseconds. waiting for 500ms ... Timeout waiting for Ajax calls to start waiting for 500ms ... √ Element /*[@id="sidebar-panel-actions-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 15 milliseconds. √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 21 milliseconds. √ Element /*[self::table[contains(@class, "files-table")] or self::div[contains(@class, "files-empty")] or self::div[contains(@class, "files-not-found")]]> was visible after 50 milliseconds. √ Element
sorry, the error was with .getText
but the issue seems to be different, i'll open a separate issue for this.
A lot of tests are failing in
getText()
command in OCIS in build: https://drone.owncloud.com/owncloud/web/25449/57/15 Maybe they're all related , maybe we're accessing elements too early or too late.
```feature Scenario: Rename a folder using special characters and check its existence after page reload # features/webUIRenameFolders/renameFolders.feature:43 - Connecting to selenium on port 4444... ℹ Connected to selenium on port 4444 (369ms). Using: chrome (94.0.4606.61) on Linux platform. Given user "Alice" has been created with default attributes and without skeleton files in the server And user "Alice" has created folder "simple-folder" in the server And user "Alice" has created folder "simple-empty-folder" in the server And user "Alice" has uploaded file "lorem.txt" to "lorem.txt" in the server And user "Alice" has logged in using the webUI √ Element was visible after 945 milliseconds. √ Element was not present after 177 milliseconds. √ Element <#files-view> was visible after 710 milliseconds. And the user has browsed to the personal page √ Element /nav[@id="files-breadcrumb"]//*[(self::a or self::button)]/span[contains(text(),'Personal')]> was visible after 187 milliseconds. When the user renames folder "simple-folder" to "लोरेम।तयक्स्त $%&" using the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 34 milliseconds. waiting for 500ms ... Timeout waiting for Ajax calls to start waiting for 500ms ... √ Element /*[@id="sidebar-panel-actions-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 11 milliseconds. √ Element <.oc-modal> was visible after 27 milliseconds. waiting for 500ms ... √ Element <.oc-modal> was not present after 201 milliseconds. And the user reloads the current page of the webUI Then folder "लोरेम।तयक्स्त $%&" should be listed on the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='लोरेम।तयक्स्त $%&' or @data-test-resource-path='/लोरेम।तयक्स्त $%&') and @data-test-resource-type='folder']/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 27 milliseconds. When the user renames folder "लोरेम।तयक्स्त $%&" to '"double"quotes' using the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='लोरेम।तयक्स्त $%&' or @data-test-resource-path='/लोरेम।तयक्स्त $%&')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 23 milliseconds. waiting for 500ms ... Timeout waiting for Ajax calls to start waiting for 500ms ... √ Element /*[@id="sidebar-panel-actions-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 13 milliseconds. √ Element <.oc-modal> was visible after 28 milliseconds. waiting for 500ms ... √ Element <.oc-modal> was not present after 181 milliseconds. And the user reloads the current page of the webUI Then folder '"double"quotes' should be listed on the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='"double"quotes' or @data-test-resource-path='/"double"quotes') and @data-test-resource-type='folder']/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 31 milliseconds. When the user renames folder '"double"quotes' to "no-double-quotes" using the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='"double"quotes' or @data-test-resource-path='/"double"quotes')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 34 milliseconds. waiting for 500ms ... Timeout waiting for Ajax calls to start waiting for 500ms ... √ Element /*[@id="sidebar-panel-actions-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 11 milliseconds. √ Element <.oc-modal> was visible after 23 milliseconds. waiting for 500ms ... √ Element <.oc-modal> was not present after 147 milliseconds. And the user reloads the current page of the webUI Then folder "no-double-quotes" should be listed on the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='no-double-quotes' or @data-test-resource-path='/no-double-quotes') and @data-test-resource-type='folder']/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 42 milliseconds. When the user renames folder 'no-double-quotes' to "hash#And&QuestionMark?At@FolderName" using the webUI √ Element /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='no-double-quotes' or @data-test-resource-path='/no-double-quotes')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 23 milliseconds. waiting for 500ms ... Timeout waiting for Ajax calls to start waiting for 500ms ... √ Element /*[@id="sidebar-panel-actions-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 14 milliseconds. √ Element <.oc-modal> was visible after 28 milliseconds. waiting for 500ms ... √ Element <.oc-modal> was not present after 134 milliseconds. And the user reloads the current page of the webUI Then folder "hash#And&QuestionMark?At@FolderName" should be listed on the webUI NoSuchElementError: An error occurred while running .getText() command on /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='hash#And&QuestionMark?At@FolderName' or @data-test-resource-path='/hash#And&QuestionMark?At@FolderName') and @data-test-resource-type='folder']>: {"sessionId":"7cf35568234c6c87cdcc108153c3ce91","status":0,"value":[]} at Proxy.checkFileName (/var/www/owncloud/web/tests/acceptance/pageObjects/FilesPageElement/filesList.js:365:18) at Proxy.waitForFileVisible (/var/www/owncloud/web/tests/acceptance/pageObjects/FilesPageElement/filesList.js:353:18) at World.webUIRenameFolders/renameFolders.feature:43
```feature Scenario: Search for files with difficult names and difficult search phrase # features/webUIFilesSearch/search.feature:146 ✔ Before # setup.js:41 ✔ Before # setup.js:45 ✔ Before # setup.js:49 ✔ Before # setup.js:66 ✔ Before # setup.js:73 ✔ Before # setup.js:84 ✔ Before # stepDefinitions/filesContext.js:17 ✔ Before # stepDefinitions/generalContext.js:199 ✔ Before # stepDefinitions/generalContext.js:237 ✔ Before # stepDefinitions/middlewareContext.js:46 ✔ Given these users have been created with default attributes and without skeleton files in the server: # stepDefinitions/middlewareContext.js:76 | username | | Alice | | user0 | ✔ And user "Alice" has created the following folders in the server # stepDefinitions/middlewareContext.js:76 | entry_name | | simple-folder | | simple-empty-folder | | strängé नेपाली folder | ✔ And user "Alice" has uploaded file "lorem.txt" to "lorem.txt" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has uploaded file "zzzz-must-be-last-file-in-folder.txt" to "zzzz-must-be-last-file-in-folder.txt" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has uploaded file "lorem.txt" to "simple-folder/lorem.txt" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has uploaded file "lorem-big.txt" to "lorem-big.txt" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has uploaded file "data.zip" to "data.zip" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has logged in using the webUI # stepDefinitions/loginContext.js:64 ✔ And the user has reloaded the current page of the webUI # stepDefinitions/filesContext.js:451 ✔ Given user "Alice" has uploaded file with content "does-not-matter" to "/strängéनेपालीloremfile.txt" in the server # stepDefinitions/middlewareContext.js:66 ✔ And the user has reloaded the current page of the webUI # stepDefinitions/filesContext.js:451 ✔ When the user searches for "strängéनेपाली" using the webUI # stepDefinitions/searchContext.js:4 ✖ Then file "strängéनेपालीloremfile.txt" should be listed on the webUI # stepDefinitions/filesContext.js:351 AssertionError [ERR_ASSERTION]: An error occurred while running .getText() command on /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='strängéनेपालीloremfile.txt' or @data-test-resource-path='/strängéनेपालीloremfile.txt') and @data-test-resource-type='file']>: at Proxy.checkFileName (/var/www/owncloud/web/tests/acceptance/pageObjects/FilesPageElement/filesList.js:375:16) at runMicrotasks (webUIFilesSearch/search.feature:146
```feature Scenario: sharing indicator for link shares stays up to date # features/webUISharingPublicManagement/publicLinkIndicator.feature:110 ✔ Before # setup.js:41 ✔ Before # setup.js:45 ✔ Before # setup.js:49 ✔ Before # setup.js:66 ✔ Before # setup.js:73 ✔ Before # setup.js:84 ✔ Before # stepDefinitions/filesContext.js:17 ✔ Before # stepDefinitions/generalContext.js:199 ✔ Before # stepDefinitions/generalContext.js:237 ✔ Before # stepDefinitions/generalContext.js:249 ✔ Before # stepDefinitions/middlewareContext.js:46 ✔ Given user "Alice" has been created with default attributes and without skeleton files in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has created folder "/simple-folder" in the server # stepDefinitions/middlewareContext.js:66 ✔ Given user "Brian" has been created with default attributes and without skeleton files in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has uploaded file "testavatar.png" to "simple-folder/testimage.png" in the server # stepDefinitions/middlewareContext.js:66 ✔ When user "Alice" has logged in using the webUI # stepDefinitions/loginContext.js:64 ✔ Then the following resources should not have share indicators on the webUI # stepDefinitions/filesContext.js:1176 | simple-folder | ✔ When the user shares folder "simple-folder" with user "Brian Murphy" as "Viewer" using the webUI # stepDefinitions/sharingContext.js:359 ✔ And the user creates a new public link for resource "simple-folder" using the webUI with # stepDefinitions/publicLinkContext.js:17 | field | value | | name | first | ✔ And the user creates a new public link for resource "simple-folder" using the webUI with # stepDefinitions/publicLinkContext.js:17 | field | value | | name | second | ✔ Then the following resources should have share indicators on the webUI # stepDefinitions/filesContext.js:1153 | fileName | expectedIndicators | | simple-folder | user-direct,link-direct | ✔ When the user opens folder "simple-folder" using the webUI # stepDefinitions/filesContext.js:155 ✔ Then the following resources should have share indicators on the webUI # stepDefinitions/filesContext.js:1153 | fileName | expectedIndicators | | testimage.png | user-indirect,link-indirect | ✔ When the user creates a new public link for resource "testimage.png" using the webUI with # stepDefinitions/publicLinkContext.js:17 | field | value | | name | third | ✔ Then the following resources should have share indicators on the webUI # stepDefinitions/filesContext.js:1153 | fileName | expectedIndicators | | testimage.png | user-indirect,link-direct | ✔ When the user removes the public link named "third" of resource "testimage.png" using the webUI # stepDefinitions/publicLinkContext.js:224 ✔ Then the following resources should have share indicators on the webUI # stepDefinitions/filesContext.js:1153 | fileName | expectedIndicators | | testimage.png | user-indirect,link-indirect | ✔ When the user opens folder "" directly on the webUI # stepDefinitions/filesContext.js:112 ✖ And the user removes the public link named "second" of resource "simple-folder" using the webUI # stepDefinitions/publicLinkContext.js:224 AssertionError [ERR_ASSERTION]: An error occurred while running .getText() command on /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]>: at Proxy.checkFileName (/var/www/owncloud/web/tests/acceptance/pageObjects/FilesPageElement/filesList.js:375:16) at runMicrotasks (webUISharingPublicManagement/publicLinkIndicator.feature:110
```feature Scenario: move a file into a folder # features/webUIMoveFilesFolders/moveFiles.feature:20 ✔ Before # setup.js:41 ✔ Before # setup.js:45 ✔ Before # setup.js:49 ✔ Before # setup.js:66 ✔ Before # setup.js:73 ✔ Before # setup.js:84 ✔ Before # stepDefinitions/filesContext.js:17 ✔ Before # stepDefinitions/generalContext.js:199 ✔ Before # stepDefinitions/generalContext.js:237 ✔ Before # stepDefinitions/middlewareContext.js:46 ✔ Given user "Alice" has been created with default attributes and without skeleton files in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has created folder "simple-folder" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has uploaded file "lorem.txt" to "lorem.txt" in the server # stepDefinitions/middlewareContext.js:66 ✔ Given user "Alice" has logged in using the webUI # stepDefinitions/loginContext.js:64 ✔ And user "Alice" has uploaded file "data.tar.gz" to "data.tar.gz" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has uploaded file "strängé filename (duplicate #2 &).txt" to "strängé filename (duplicate #2 &).txt" in the server # stepDefinitions/middlewareContext.js:66 ✔ And user "Alice" has created folder "strängé नेपाली folder empty" in the server # stepDefinitions/middlewareContext.js:66 ✔ And the user has reloaded the current page of the webUI # stepDefinitions/filesContext.js:451 ✔ When the user moves file "lorem.txt" into folder "simple-folder" using the webUI # stepDefinitions/filesContext.js:1212 ✔ Then breadcrumb for folder "simple-folder" should be displayed on the webUI # stepDefinitions/filesContext.js:202 ✔ And file "lorem.txt" should be listed on the webUI # stepDefinitions/filesContext.js:351 ✔ When the user browses to the files page # stepDefinitions/filesContext.js:22 ✖ And the user moves file "data.tar.gz" into folder "strängé नेपाली folder empty" using the webUI # stepDefinitions/filesContext.js:1212 AssertionError [ERR_ASSERTION]: An error occurred while running .getText() command on /span[contains(@class, "oc-resource-name") and (@data-test-resource-name='data.tar.gz' or @data-test-resource-path='/data.tar.gz')]>: at Proxy.checkFileName (/var/www/owncloud/web/tests/acceptance/pageObjects/FilesPageElement/filesList.js:375:16) at runMicrotasks (webUIMoveFilesFolders/moveFiles.feature:20
TODO