Release 5.7.0 - Githubissues

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale

GNU Affero General Public License v3.0

443 stars 157 forks source link

Release checklist

[x] pin release issue @kulmann

[ ] release & bump ODS if needed

[ ] release & bump SDK if needed

[x] prepare release rc

[x] create a branch release-5.7.0 @kulmann
[x] update the version in packages/web-integration-oc10/appinfo/info.xml @kulmann
[x] update the version in package.json @kulmann
[x] update the version in sonar-project.properties @kulmann
[x] move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @kulmann
[x] update the ocis commit id in .drone.env to the most recent one from ocis master (let's see how it goes) @kulmann
[x] commit, push and create draft PR for this branch @kulmann

[x] create pre release tag v5.7.0-rc.1 from the release branch @kulmann (2022-06-23)

[x] create pre release tag v5.7.0-rc.2 from the release branch @kulmann (2022-07-07)

[x] create pre release tag v5.7.0-rc.3 from the release branch @kulmann (2022-07-07)

[x] create pre release tag v5.7.0-rc.4 from the release branch @kulmann (2022-07-08)

[x] create pre release tag v5.7.0-rc.5 from the release branch @pascalwengerter (2022-07-11)

[x] create pre release tag v5.7.0-rc.6 from the release branch @kulmann (2022-08-01)

[x] create pre-release tag v5.7.0-rc.7 from the release branch @kulmann (2022-08-02)

[x] create pre-release tag v5.7.0-rc.8 from the release branch @kulmann (2022-08-08)

[x] create pre-release tag v5.7.0-rc.9 from the release branch @kulmann (2022-08-10)

[x] create pre-release tag v5.7.0-rc.10 from the release branch @kulmann (2022-08-23)

[x] create pre-release tag v5.7.0-rc.11 from the release branch @kulmann (2022-09-02)

[x] create pre-release tag v5.7.0-rc.12 from the release branch @kulmann (2022-09-08)

[x] smoke test

[x] against oCIS
[x] against oc10 as app installation
[ ] against oCIS wopi example / app provider
[x] against oc10 with onlyoffice app, because https://github.com/owncloud/web/pull/7072 was merged
[x] against oc10 with richdocuments app, because https://github.com/owncloud/web/pull/7072 was merged

[x] if needed, fix issues or write down known issues

[x] update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD

[x] Make sure translations are up to date by updating them in Transifex and restarting translation sync job https://drone.owncloud.com/owncloud/translation-sync/

repeat above steps if a new rc is needed

[x] Run translations sync job once again

[x] go to the releases section and click Draft a new Release. Use v5.7.0 as a tag (the v prefix is important) and 5.7.0 as name and publish it

[x] ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com

[x] merge release branch back to master (CI must be green)

v5.7.0-rc.5

Case 1: admin share folder(with file) to marie:

Admin:

[x] upload big file 10gb (Show details, pause upload, resume upload work correct)
[x] upload folder with 803 small images.
[x] Check pagination, count items per page. Have a bug https://github.com/owncloud/web/issues/6768
[x] upload folder(drag folder) "folder_to_share" with file.pdf
[x] share folder "folder_to_share" to marie with edit right

Marie:

[x] accept "folder_to_share"
[x] re-share to einstein as viewer (ensure that einstein gets file)
[x] rename "folder_to_share" - cannot rename folder in new implementation
[x] upload new file "file.txt" to "folder_to_share" (admin see new file)
[x] open pdf file
[x] rename file.pdf (use rigth click) (admin see that file changed name)

Einstein:

[x] accept file
[x] cannot rename/move/delete/upload file in folder and cannot create new document in the folder

Admin:

[x] add new file.jpeg to "folder_to_share"
[x] move file.pdf to root "personal" (marie can not see file.pdf)
[x] add new "file.txt" create new version. (use drag and drop)
[x] open txt file in markdown-editor. Change and save.

Marie:

[x] can download both versions
[x] restore old version

Einstein:

[x] can download only last version
[x] cannot restore old version

Marie:

[x] decline folder (removed from shares folder) - Einstein still has a folder
[x] accept again

Admin:

[x] delete folder "folder_to_share" (removed from shared with me, removed from Marie and Einstein)

Case 2: admin share file to marie:

Admin:

[x] upload file.jpeg
[x] share file.jpeg to "user" group

Marie:

[x] accept file (marie can open/download/copy file but cannot delete/move/rename) - cannot copy paste in share jail
[x] open file in Mediaviewer
[x] download file

Admin:

[x] share "file.txt" with rigth edit (use main menu. find marie by email marie@example.org)

Marie:

[x] rename file - cannot rename in new implementation
[x] change content of the file (can see new version) - cannot see version. Here bug: https://github.com/owncloud/web/issues/7159

Admin:

[x] unshare "file.jpeg" (marie cannot see "file.jpeg")

Case 3: admin create public links to folder

Admin:

[x] create folder "for upload"
[x] add link with name "to_upload" with role "Uploader" with pass and expiration date
[x] open link (can only upload)
[x] upload file (admin can see new file)
[x] change share "for upload" from "Uploader" to "edit"
[x] admin add new file to folder "for upload"
[x] refresh link (file exist)
[x] admin change pass (refresh link has to type new pass)

Case 4: admin create link to file

Admin:

[x] create file png
[x] add link with main menu
[x] open link(can open, download, see) in the incognito tab
[x] change link, add pass
[x] refresh page (input pass)
[x] delete link
[x] refresh page (resource not found)
[x] delete file
[x] restore
[x] delete
[x] Empty trash

Case 5: space story:

Katherine:

[x] create space
[x] add space image
[x] add subtitle "for test"
[x] edit description
[x] try to upload file (more 1 Gb)
[x] increase quota to 5Gb and try again
[x] delete file
[x] add member Marie with edit role
[x] add member Einstein with viewer role

Marie:

[x] can see space without accepting
[x] change image and description
[x] can upload file/folder and create file and folder
[x] cannot create resource sharing and space sharing
[x] can see deleted files and can restore files from trash
[x] cannot disable space

Einstein:

[x] can see space without accepting
[x] cannot change image and description
[x] cannot upload file/folder and create file and folder
[x] cannot create resource sharing and space sharing
[x] can see deleted files and cannot restore files from trash
[x] cannot disable space

Katherine change Einstein role to manager

Case 6: create new user via accounts:

Admin (test via api):

[x] create new account "tom" use graph Api
[x] create new group
[x] share folder with group
[x] change language
[x] delete users

Remarks:

`12T11:43:51Z ERR failed to send a message error="rpc error: code = Unknown desc = gateway: error calling GetGroup: rpc error: code = Unauthenticated desc = auth: core access token not found" event=ShareCreated service=notifications

2022-07-12T11:43:59Z ERR failed to send a message error="could not send mail: dial tcp 127.0.0.1:1025: connect: connection refused" event=ShareCreated service=notifications`

sometimes appears error when you try open jpg file. 2022-07-12T12:11:15Z ERR could not get thumbnail error="{\"id\":\"go.micro.client\",\"code\":408,\"detail\":\"context deadline exceeded\",\"status\":\"Request Timeout\"}" service=webdav
search in public link is broken??
search by share jail: https://github.com/owncloud/web/issues/7212
https://github.com/owncloud/web/issues/7268
https://github.com/owncloud/web/issues/7269

smoke testing v5.7.0-rc.11 with web as oc10-app

❌ as gunter - upload arch/mips folder from linux kernel (1801 files)
- ❌ via drag and drop folder upload broken.
- :heavy_check_mark: via folder upload button works
:heavy_check_mark: as gunter - share the folder to alice as viewer
:heavy_check_mark: as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)
:heavy_check_mark: as alice - try do delete file from shared folder
- individual delete action not visible, good
- batch delete action not visible, good
- context menu action not visible, good
:heavy_check_mark: as alice - try to add file
- not possible (which is expected)
- drag & drop upload handle it with an error (which is good)
:heavy_check_mark: as alice - copy 16 folders from share to home (via copy & paste actions above table)-
- no visible feedback that it's in progress, but works
:heavy_check_mark: as alice - copy 16 folders from share to home (via keyboard actions cmd+c / cmd+v)
:heavy_check_mark: as gunter - add a file (some image) to share
:heavy_check_mark: as alice - receive new file in existing share
- visible in file list
- can be opened in preview app
:heavy_check_mark: as gunter - unshare folder from shared with others
:heavy_check_mark: as alice - try to revisit old share
- shows resource not found upon page reload, good
- going back to All files or Shared with me doesn't list the share anymore, good
:heavy_check_mark: as gunter - share folder with alice again, but as editor
- setting and removing an expiration date work as expected, good
:heavy_check_mark: as alice - rename a file
- via right sidebar, works, good
- via context menu, works, good
:heavy_check_mark: as gunter - add file
:heavy_check_mark: as alice - delete file
- via right sidebar, works, good
- via context menu, works, good
- via batch action, works, good
:heavy_check_mark: as alice - create quick link on any folder
:heavy_check_mark: as alice delete file and recover it
:heavy_check_mark: as alice create version of textfile
:heavy_check_mark: as alice view version history of text file
:heavy_check_mark: as alice download newest version of text file
:heavy_check_mark: download older version of text file
:heavy_check_mark: restore older version of text file
- no visible feedback about the success
- preview is not updated
:heavy_check_mark: as alice - upload avatar in classic UI
- see own avatar in top bar (far right)
- login as gunter, having a share with alice
  - shared with others page loads
  - avatar of alice is not shown (bad)
:heavy_check_mark: as alice, move a file into subfolder via drag and drop
:heavy_check_mark: as alice, move multiple files & folders into subfolder via drag and drop
:heavy_check_mark: as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Remarks / findings

[x] font embedding is broken (release blocker) -> fixed in https://github.com/owncloud/web/pull/7605/commits/2f5cd3fad90fe1fdbce822991fd4bd90fbe91de2
[x] drag and drop folder upload is broken, see screenshot (release blocker) -> seems to be an issue when using http (i.e. without ssl). needs to be confirmed. Would not be a release blocker then. -> confirmed that this doesn't happen with https connection.

more context: broken in Google Chrome. Safari works as expected though.

[x] navigate into "shared with me" page without shares, shows console error
```
[Vue warn]: Invalid prop: type check failed for prop "sortBy". Expected String, got Undefined 
```
(not a release blocker), fixed on release branch

owncloud / web

Release 5.7.0 #7219

Release checklist

Case 1: admin share folder(with file) to marie:

Case 2: admin share file to marie:

Case 3: admin create public links to folder

Case 4: admin create link to file

Case 5: space story:

Case 6: create new user via accounts:

smoke testing v5.7.0-rc.11 with web as oc10-app

Remarks / findings