owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
443 stars 157 forks source link

Login form design improvement #7552

Closed hurradieweltgehtunter closed 2 years ago

hurradieweltgehtunter commented 2 years ago

Steps to reproduce

  1. Loadup login screen

Actual behaviour

grafik

Design and, thus, readability could be improved.

Updated oCIS login screen

grafik

OC10

Have a look at the OC10 login screen: grafik

When we updated it some time ago we considered best practices for login screens. I'd suggest to use this result instead of reinvent the wheel.

Environment general

https://ocis.ocis-wopi.latest.owncloud.works

kulmann commented 2 years ago

Note: this needs to be implemented in https://github.com/owncloud/ocis as the code of the idp service (including the frontend) lives there. Still fine to track it here.

kulmann commented 2 years ago

I'd prefer a gray-ish text color for the (muted) placeholder text in the form fields, like it is in oc10 as well. What do you think?

hurradieweltgehtunter commented 2 years ago

Maybe this leads too far but using a label and a placeholder to show the same information is a duplicate without additional purpose. If a label is present a good best practice might be to use the placeholder to show an example value like 'john@example.com'

JammingBen commented 2 years ago

Okay for now as stated here: https://github.com/owncloud/ocis/pull/4500#issuecomment-1235575435