owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
443 stars 157 forks source link

[spaces] cannot select 1GB quota as quota on new space #8641

Closed hurradieweltgehtunter closed 1 year ago

hurradieweltgehtunter commented 1 year ago

Steps to reproduce

  1. Create space
  2. Edit quota
  3. Select 1GB

Expected behaviour

Quota can be confirmed and stored

Actual behaviour

Button "Confirm" is disabled

When selecting an other quota, saving it, edit quota again -> 1GB can be selected.

Edit: Further digging: It seems, that the already stored quota value cannot be selected and stored again. Edit quota -> Select "2GB" -> save -> edit quota again -> Select 2GB -> Button is disabled. This is ok, if a quota is selected. But for new spaces without a quota setting it seems that the select field has the first option "1GB" pre-selected, although there is no 1GB quota. This results in disabling the "Confirm" button.

Proposal: Add an option "Select quota or enter value" as pre-selected option.

grafik

Environment general

https://ocis.ocis-wopi.latest.owncloud.works

JammingBen commented 1 year ago

But for new spaces without a quota setting it seems that the select field has the first option "1GB" pre-selected, although there is no 1GB quota.

No, 1 GB is pre-selected because it is the current value. A new space gets created with 1 GB default quota.

Proposal: Add an option "Select quota or enter value" as pre-selected option.

This won't work, because again, 1 GB is the value the space actually has.

ChrisEdS commented 1 year ago

Maybe add a small (current value) text behind?

JammingBen commented 1 year ago

Maybe add a small (current value) text behind?

We could do that, but it adds more complexity and I'm honestly not sure it's worth the effort. I mean, the current behaviour is just how select inputs are generally designed: they display the current value and let you select other values.

Maybe the confusing thing here is the fact that the select field opens automatically? Because it draws the attention from the currently selected value and instead gives the user the impression "Hey, I don't have any value currently, please select something".

hurradieweltgehtunter commented 1 year ago

I checked again. What confused me in the first place was that I clicked on a disabled space. Disabled spaces show - as remaining space in the admin settings spaces overview. For me, it was not recognizable which quota settings were applied for this specific space, so I got confused even more when I could not select 1GB. My idea would be to show the remaining space for disabled spaces, too. And, show the quota settings. For example: Remaining quota: 345MB / 1 GB

JammingBen commented 1 year ago

My idea would be to show the remaining space for disabled spaces, too. And, show the quota settings. For example: Remaining quota: 345MB / 1 GB

We would like to do that, but the server does not provide that data for disabled spaces :( Which raises the question for me: does it make sense to show the "Edit quota"-action for disabled spaces?

hurradieweltgehtunter commented 1 year ago

My idea would be to show the remaining space for disabled spaces, too. And, show the quota settings. For example: Remaining quota: 345MB / 1 GB

We would like to do that, but the server does not provide that data for disabled spaces :( Which raises the question for me: does it make sense to show the "Edit quota"-action for disabled spaces?

This would relate to: https://github.com/owncloud/web/issues/8642

But apart from being able to change the quota it must be possible to show these values, even on disabled spaces.

hurradieweltgehtunter commented 1 year ago

Now I'm confused. A lot. Are these columns in the space overview in admin settings new?

grafik
kulmann commented 1 year ago

Now I'm confused. A lot. Are these columns in the space overview in admin settings new?

grafik

Not new. They are hidden when your browser window is too smal.

hurradieweltgehtunter commented 1 year ago

🤦 wow … ok, then it's my fault, apparently. sorry.