search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
443 stars 157 forks source link

[web-app-search] No visible difference between folders and spaces in search results #8925

Closed hurradieweltgehtunter closed 1 year ago

hurradieweltgehtunter commented 1 year ago

Steps to reproduce

  1. Make sure to have min 1 folder and a space created with the same name
  2. Search this name in global search

Expected behaviour

Saerch results are somehow differentiated based on their type (folder, space, ...)

Actual behaviour

No difference visible

First search result in screenshot (top list and full view list) is a space, other are folders (see edit pen, rename possible for folders, not for spaces)

grafik

Also, I expected that the dropdown result list would segment results based in their type (see top left "Files")

https://ocis.ocis-wopi.latest.owncloud.works

hurradieweltgehtunter commented 1 year ago

sth like this would be nice

grafik

kulmann commented 1 year ago

Doable by splitting the search provider in the files app into two different providers, one filtering out spaces from the result set, the other one filtering everything but spaces out. This would be reasonable effort for the search result preview. But we should consider the full picture here - hitting Enter the user lands on a search result page. That should take the same thoughts into account.

There are some more more or less related issues:

And there is also the idea that the search preview does even more segmentations:

Nice enhancement, but needs more concepting. :-)

tbsbdr commented 1 year ago

I'd stick to the scheme and show the following, if the result is a Space:

  1. display "Spaces" as parent folder
  2. show Space Image/Icon if

screenshot_000847

JammingBen commented 1 year ago

I stumbled upon this while fixing https://github.com/owncloud/web/issues/9022.

Doable by splitting the search provider in the files app into two different providers, one filtering out spaces from the result set, the other one filtering everything but spaces out.

@kulmann Do we really need separate search providers for this? My current fix (https://github.com/owncloud/web/pull/9026) simply adjusts the existing search provider and returns the correct space resource if found.

kulmann commented 1 year ago

I stumbled upon this while fixing #9022.

Doable by splitting the search provider in the files app into two different providers, one filtering out spaces from the result set, the other one filtering everything but spaces out.

@kulmann Do we really need separate search providers for this? My current fix (#9026) simply adjusts the existing search provider and returns the correct space resource if found.

Your solution is good. 👍

JammingBen commented 1 year ago

Fixed via https://github.com/owncloud/web/pull/9026.