owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
418 stars 157 forks source link

Dialogs not using <form> elements #9016

Open hurradieweltgehtunter opened 1 year ago

hurradieweltgehtunter commented 1 year ago

Example: Edit Tags

https://github.com/owncloud/web/blob/2d5f5d6d7ba60eb73f4dd863e55c49766742c3e9/packages/web-app-files/src/components/SideBar/TagsPanel.vue#L3

Instead of having a

element, which captures the submitevent, a divis used. This means that the submit button click needs to be captured manually (button event "confirm").

Relates to https://github.com/owncloud/web/issues/8897 (3rd point)

Also is an a11y issue.

hurradieweltgehtunter commented 1 year ago

Seems are not used anywhere (modals, forms, etc), not only in right sidebar.