search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
443 stars 157 forks source link

HTML lang attribute not set on load #9288

Closed hurradieweltgehtunter closed 11 months ago

hurradieweltgehtunter commented 1 year ago

Steps to reproduce

Make sure to have a non-english language set

  1. Login
  2. Check lang attribute on html element in dev console

Expected behaviour

attribute should be set to same language as the page is displayed

Actual behaviour

Attribute is initially (= after login) set to en although the visible language is a different one.

AFAIK this should be set correctly for accessibility reasons.

https://ocis.ocis-wopi.latest.owncloud.works/

AlexAndBear commented 1 year ago

I can't reproduce this, please reopen and add detailed steps if you think the error still persists

hurradieweltgehtunter commented 1 year ago
  1. Make sure you have set non-english language on your account (in my example: german)
  2. Login in private tab
  3. Open dev-console, check lang attribute on <html> element

-> it is set to en no matter what. Changes if you change the language after login and gets set correctly if you login and login in the same browser. It seems that if there's no language setting stored in web storage it gets not set correctly.

jacob-nv commented 1 year ago

@hurradieweltgehtunter @JammingBen Not able to reproduce it, maybe it's fixed by now. Did I miss any steps?

https://github.com/owncloud/web/assets/138569835/78f8cdeb-aff2-4aa5-a1f1-a6757a22a1b8

JammingBen commented 1 year ago

I can't reproduce the issue either. @hurradieweltgehtunter could you please try again, maybe it has been fixed meanwhile? Or if the issue still exists for you, mind sharing a short screen capture? 🙂

JammingBen commented 11 months ago

Closing here since nobody can reproduce it here. Feel free to re-open at any time if necessary.