search

owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
440 stars 157 forks source link

Add standard actions to file control bar #9491

Open tbsbdr opened 1 year ago

tbsbdr commented 1 year ago

Steps to reproduce

  1. open a only office file in web
  2. available actions in file control bar is X (close)

screenshot_001455

Expected behaviour

  1. Save (if available)
  2. 3-dots (see cernbox for good example)

Actual behaviour

pascalwengerter commented 1 year ago

@tbsbdr could you provide a list of actions, ideally prioritized, that you'd expect to be placed inside the three-dot menu?

Technical background: The actions that are used within the three-dots-/context-menu and sidebar currently live within the web-app-files and have dependencies within it (sometimes multiple levels deep), but need to be moved to the web-pkg so they're available for other, non files-app apps

kulmann commented 1 year ago

@tbsbdr could you provide a list of actions, ideally prioritized, that you'd expect to be placed inside the three-dot menu?

Technical background: The actions that are used within the three-dots-/context-menu and sidebar currently live within the web-app-files and have dependencies within it (sometimes multiple levels deep), but need to be moved to the web-pkg so they're available for other, non files-app apps

Not necessarily. Please have a chat with @dschmidt about this. Apps can now register extensions. So I think a valid approach would be that the files app registers all the file actions as extensions in the runtime. This also ensures that "file actions" are only available (but then system wide) if the files app is installed, which IMO is a good thing.