owncloud / web

:dragon_face: Next generation frontend for ownCloud Infinite Scale
https://owncloud.dev/clients/web/
GNU Affero General Public License v3.0
444 stars 157 forks source link

[web] Provide "Convert to PDF" Action #9859

Open tbsbdr opened 1 year ago

tbsbdr commented 1 year ago

Description

User Stories

Value

Acceptance Criteria

* needs a generic approach in the future that works with other PDF converters; not part of this story

Note: Convertig multiple files at once and an info on about postprocessing status is not part of this story. this could be tackeled within a workfow

Please track times

Definition of ready

[ ] everybody needs to understand the value written in the user story [ ] acceptance criteria has to be defined [ ] all dependencies of the user story need to be identified [ ] feature should be seen from an end user perspective [ ] user story has to be estimated [ ] story points need to be less then 20

Definition of done

Visuals

Image

dj4oC commented 1 year ago

Why is this not a web only ticket if onlyoffice document server already provides and exposes this API? https://api.onlyoffice.com/editors/conversionapi

dschmidt commented 1 year ago

This ticket is in Web repo?!

Why is this not a web only ticket if onlyoffice document server already provides and exposes this API? https://api.onlyoffice.com/editors/conversionapi

tbsbdr commented 1 year ago

@kulmann could you please add some bullets what we need from the backend for this ticket?

kulmann commented 1 year ago

@kulmann could you please add some bullets what we need from the backend for this ticket?

Another option would be that we develop the file action as a standalone extension. In that case we wouldn't need the capability and could rely on the web config instead. In that case we'd put even more config aspects into the hands of the admin. Doesn't look like a good idea to me nowadays. Also we would loose the chance to offer the action in all clients and would again build a web-only feature.

kulmann commented 1 year ago

Why is this not a web only ticket if onlyoffice document server already provides and exposes this API? https://api.onlyoffice.com/editors/conversionapi

See comment before. It's not about the heavy lifting of converting documents to pdfs. It's about connecting the pieces - oCIS needs to do that. Wild guessing by clients ™️ is not something we do here. The clients don't know that the API exists or how to make use of it.

dj4oC commented 1 year ago

Why don't we make an extension out of it? How does the Web know that there is an app provider with OnlyOffice?

dschmidt commented 1 year ago

I'd like to add - handling conversion server side would reduce traffic to the browser

kulmann commented 1 year ago

I'd like to add - handling conversion server side would reduce traffic to the browse

Why don't we make an extension out of it? How does the Web know that there is an app provider with OnlyOffice?

Well, web actually doesn’t know anything about OnlyOffice. It just lists all the available apps from the app provider. You can search the web code base. You won’t find a single line about OnlyOffice.

We can have a custom extension in another repo if there is a need for it. ;-) But this issue is about the product, not consulting, so I‘d like to go the extra mile with a little bit of backend involvement. Sprint is already full anyway.

also: edited my initial comment because I misread „extension“ as „exception“, which I was not so happy about. 😅

kulmann commented 1 year ago

I‘d like to emphasize again that this feature makes sense for all clients from a product perspective @tbsbdr - even if we only implement it for web now, we should make it possible for other clients as well. With a web only extension that would not work.

dj4oC commented 6 months ago

I would like to bring this up again. Would the Extension System been capable of this today? If yes: What limitations would ease up the implementation?

AlexAndBear commented 5 months ago

I would like to bring this up again. Would the Extension System been capable of this today?

Could you define your question a little more? I don't get the connection between the extension system and the pdf converter in general.