owntone / owntone-server

Linux/FreeBSD DAAP (iTunes) and MPD audio server with support for AirPlay 1 and 2 speakers (multiroom), Apple Remote (and compatibles), Chromecast, Spotify and internet radio.
https://owntone.github.io/owntone-server
GNU General Public License v2.0
2.03k stars 234 forks source link

Fix last.fm scrobbling behaviour and support now playing #1321

Open surskitt opened 2 years ago

surskitt commented 2 years ago

It seems like owntone isn't scrobbling as last.fm suggests. A track is only scrobbled once the full track has been played, but according to this section of the documentation, scrobbling should happen when:

the track has been played for at least half its duration, or for 4 minutes (whichever occurs earlier.)

Also, it would be good to support the now playing functionality, which gets sent to last.fm as soon as a track begins to play. It is described here and the api call is here.

Thanks!

ejurgensen commented 2 years ago

Sounds fine. I'll add the "help wanted" tag since I probably won't get around to this myself.

surskitt commented 2 years ago

Thanks! I'd try handle it myself but I don't really know C unfortunately.

dreikelvin commented 5 months ago

Hi there! I just installed linuxserver/daapd (aka "Owntone") on my synology NAS via docker and it seems like Last.fm scrobbling is not working properly at all. None of the tracks I play - either via Apple Music or in the web frontent are showing up in my Last.fm profile. At least not if you just play a quick section of it. I assume that this issue has been known since Oct 2021 and nobody has gotten around fixing it :P I don't know C either, sorry. Just what an Oscillator is and how you fix phasing issues in a mix haha

ejurgensen commented 5 months ago

At least not if you just play a quick section of it

OwnTone scrobbles when the entire track has been played. Only if it's played by OwnTone, so not Apple Music. I think that should work, I tested it not too long ago.

dreikelvin commented 5 months ago

You're right! I just tested it in Apple Music and it doesn't scrobble at all. Any way to fix this? I was assuming that Apple Music basically access the same api as the owntone web interface.

ejurgensen commented 5 months ago

Now I actually looked at the code, and I see scrobbling is supposed to work also with Apple Music. I'll have to test that to see what the issue might be.