search

owntone / owntone-server

Linux/FreeBSD DAAP (iTunes) and MPD audio server with support for AirPlay 1 and 2 speakers (multiroom), Apple Remote (and compatibles), Chromecast, Spotify and internet radio.
https://owntone.github.io/owntone-server
GNU General Public License v2.0
2.07k stars 236 forks source link

Shairport-sync pipe iOS metadata volume sets to 0 #1366

Closed greend139 closed 2 years ago

greend139 commented 2 years ago

When changing volume from iOS music app, which is playing to Shairport-sync pipe output to owntone the following is received in the logs and the volume is set to 0

Previously to building today the volume just didn't change. I have Shairport volume being ignored in Shairport-sync.conf (ignore_volume_control = "yes";)

daapd    | [2021-12-11 13:58:54] [DEBUG]   player: Applying Shairport metadata (type=ssnc, code=pvol, len=25)
daapd    | [2021-12-11 13:58:54] [DEBUG]   player: Not applying Shairport airplay volume while software volume control is enabled (-11.25,-18.06,-96.30,0.00)
daapd    | [2021-12-11 13:58:54] [DEBUG]   player: Status update - status: 4, events: 4, caller: volume_generic_bh

running owntone server built from master (d6cc0e453def1871ce776424c6505913cb2ef5a7) shairport-sync development --with-airplay2. (4.1-dev-101-gfbce5906-AirPlay2-alac-OpenSSL-Avahi-ALSA-dummy-stdout-pipe-soxr-convolution-metadata-mqtt-dbus-mpris-sysconfdir:/etc)

Any help would be appreciated.

ejurgensen commented 2 years ago

Thanks for notifying. Looks like I've made a regression, I will fix it asap.

ejurgensen commented 2 years ago

I think this should be fixed now, hope you can test and verify.

greend139 commented 2 years ago

Thats for the fix! Owntone is no longer applying the invalid metadata.