search

owntone / owntone-server

Linux/FreeBSD DAAP (iTunes) and MPD media server with support for AirPlay 1 and 2 speakers (multiroom), Apple Remote (and compatibles), Chromecast, Spotify and internet radio.
https://owntone.github.io/owntone-server
GNU General Public License v2.0
1.99k stars 227 forks source link

does not build without sys/queue.h #1726

Closed neheb closed 3 months ago

neheb commented 3 months ago

musl libc does not include sys/queue.h, making compilation fail:

httpd_libevhttp.c:26:10: fatal error: sys/queue.h: No such file or directory
   26 | #include <sys/queue.h> // TAILQ_FOREACH
      |          ^~~~~~~~~~~~~
compilation terminated.

libbsd can be added as a dependency to work around.

hacketiwack commented 3 months ago

@neheb, which procedure of this documentation did you follow?

ejurgensen commented 3 months ago

@neheb is openwrt maintainer so I'm guessing he noticed the error from one of the buildbots. I will make a fix for it.

ejurgensen commented 3 months ago

Thanks for reporting @neheb, I think it should be fixed with the above patch. I haven't gotten around to updating the openwrt/packages version to 28.9, but when I do I guess I can either include this patch or add the libbsd dependency you mention.

neheb commented 3 months ago

Musl in OpenWrt is patched to include a sys/queue.h . Should be eliminated honestly to reduce the amount of patching, which is what I’ve done locally.

Don’t remember if this is the only usage in the code base.