owntracks / android

OwnTracks Android App
http://owntracks.org
Eclipse Public License 1.0
1.39k stars 476 forks source link

locatorPriority unrecognised in setConfiguration #1874

Closed JuliusFruitfly closed 1 month ago

JuliusFruitfly commented 1 month ago

'locatorPriority' is documented as an integer 0..3, but when setting a value with setConfiguration the log contains:-

D [DefaultDispatcher-worker-3] Preferences: Importing configuration key locatorPriority -> 2 I [DefaultDispatcher-worker-3] Preferences: Unknown preference key locatorPriority

and

I [DefaultDispatcher-worker-3] PreferencesStore: Setting default preference value for locatorPriority to null D [DefaultDispatcher-worker-3] PreferencesStore: Setting preference locatorPriority to null (coerced to null)

Is this parameter no longer supported?

Thanks

growse commented 1 month ago

~Yep, we took it out. It was not widely used, and causing a bunch of confusion.~

I'm mistaken - I was thinking of another one. This should work? Let me test quickly.

growse commented 1 month ago

Ok, so the issue is that locatorPriority only responded to the value being the name version of the string representation of the enum, not the number (that it used to be). So, a regression.