Tour submission (cmd) isn't encrypted in payload

owntracks / ios

OwnTracks' iPhone App

http://owntracks.org

Other

331 stars 91 forks source link

Tour submission (cmd) isn't encrypted in payload #773

Closed jpmens closed 8 months ago

jpmens commented 8 months ago

I'm not sure this is a bug, more like a discussion point:

I notice that creating and submitting a Tour causes an MQTT publish with a clear-text payload in spite of secret key encryption being enabled on iOS / Recorder.

I tend to think we should encrypt these payloads as well.

ckrey commented 8 months ago

All messages from the app are encrypted if the encryption key is set. The encryption key cannot be set remotely (via .otrc, inline url, or cmd)

jpmens commented 8 months ago

+++++ [owntracks/jip/iPad/request (plen=239, r=0) [{"_type":"encrypted","data":"pFlC...
+++++ [Key for jip-ipad is [...
+++++ [START DECRYPT. clen==155]
+++++ [DECRYPTED: {"_type":"request","request":"tour","tour":{"from":"2024-02-...
+++++ [owntracks/jip/iPad/request (plen=115, r=0) [{"_type":"request","request":"tour","tour":{"fro