owntracks / recorder

Store and access data published by OwnTracks apps
Other
894 stars 123 forks source link

Check payload for binary contents and \0 in string #2

Closed ckrey closed 9 years ago

ckrey commented 9 years ago
cc -Wall -Werror -g ot-recorder.c -o ot-recorder json.o geo.o geohash.o mkpath.o file.o safewrite.o base64.o ghash.o -lmosquitto -lcurl -lhiredis
ot-recorder.c: In function ‘on_message’:
ot-recorder.c:375:2: error: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘void * const’ [-Werror=format]
ot-recorder.c:424:5: error: format ‘%s’ expects argument of type ‘char *’, but argument 5 has type ‘void * const’ [-Werror=format]
cc1: all warnings being treated as errors
jpmens commented 9 years ago

Did you build this on Linux? OS X doesn't complain..

Even so, yes: we need a hexdumper in case payload has binary in it.

jpmens commented 9 years ago

We need to check if this is being used consistently throughout

ckrey commented 9 years ago

yes, built on raspbian