search

owntracks / recorder

Store and access data published by OwnTracks apps
Other
907 stars 123 forks source link

unix socket support #470

Closed cyberb closed 5 months ago

cyberb commented 5 months ago

Hi,

I know you may not want this but just in case, this adds a unix socket support. As I understand upstream mangoose does not support it either yet and I guess this project has a 10 year old version of it so I think I have higher chances adding it here. This fork will be used in Syncloud project.

Sorry this is first c PR in my life.

Change allows the following config:

OTR_HTTPHOST=/path/to/socket.file
jpmens commented 5 months ago

The reason we use an old version of mongoose is that during initial Recorder development, IIRC, we were confronted with several API changes in mongoose, and I simply didn't want to invest the effort in keeping up.

Your efforts here are commendable but I fear they're misplaced: we don't think it's a good idea to patch this old version, in particular if we do decide to upgrade mongoose, we'd have to backport Unix domain sockets to the new version, which is something we'd not wish to do.

Might I suggest you approach mongoose with your patch.