owodzeg / V4Hero

Client for Patafour, a Patapon fangame.
GNU General Public License v3.0
52 stars 14 forks source link

Severe bugs found by CppCheck #97

Closed Nemoumbra closed 5 months ago

Nemoumbra commented 5 months ago

image

The rest are not too bad for a hotfix to be required, but these are just the worst. I got SIGILL because of that:

Pon* PonRegistry::GetPonByID(int id)
{
    for (int i = 0; i < pons.size(); i++)
    {
        if (i == id)
        {
            return &pons[i];
        }
    }

    cout << "PonRegistry could not find the appropriate Pon" << endl;
}
owodzeg commented 5 months ago

fixed in 2c1d865