owsas / opensource

Collection of Open Source packages by Otherwise
23 stars 4 forks source link

[nominatim-js] Missing dependency cross-fetch #185

Open Delivator opened 4 years ago

Delivator commented 4 years ago

After installing with npm install --save @owsas/nominatim-js and importing with const { NominatimJS } = require('@owsas/nominatim-js'); it throws an error on build:


ERROR  Failed to compile with 1 errors
This dependency was not found:

* cross-fetch in ./node_modules/@owsas/nominatim-js/dist/nominatim-js.js

To install it, you can run: npm install --save cross-fetch```
github-actions[bot] commented 4 years ago

This is your first issue on our repo :) Thank you!

ms-clovis commented 5 months ago

Is this issue going to be fixed?

jcguarinpenaranda commented 5 months ago

Hello @Delivator @ms-clovis, could you please try as suggested in the error log reported?

To install it, you can run: npm install --save cross-fetch

ms-clovis commented 5 months ago

Sorry to be pushy, but I thought you were going to get to the issues and commit to the NPM repo.. Are you going to be able to do that?

jcguarinpenaranda commented 5 months ago

Hello,

I tried reproducing your error to no avail. I created the following repository to test your scenario and it just works for me. Are you sure you installed cross-fetch?

Test repo: https://github.com/owsas/test-nominatim

Results running node index.js:

Screenshot 2024-05-23 at 09 54 31

Could you please try that repository out? Are you using any special technology stack not allowing you to do this?

ms-clovis commented 5 months ago

Your test repository works fine.... Using NPM list in my Vue project the versions of Nominatim-js and cross-fetch are the same. I am unsure where to go now.