search

owsolutions / amazing-time-picker

Timepicker (Clock Picker) for Angular 2, Angular 4 and Angular 5, Angular 6, Angular 7 - Compatible with Angular Material
137 stars 76 forks source link

Add animation #57

Closed smitelij closed 6 years ago

smitelij commented 6 years ago

I wanted to add the ability to animate the clock hand when we are automatically changing the display from hours to minutes, and when we are flipping back and forth between hours and minutes.

There is still room for improvement in calculating the target degree- the intent is to never rotate more than 180degrees, but sometimes it will do more than a full rotation before landing at the target spot.

I followed the similar HTML directive pattern established.

torabian commented 6 years ago

There are so many conflicts with this, please resolve them and notify us.

torabian commented 6 years ago

Conflicts on this pull request are getting higher and higher. Please fix them and then we can publish this on version 1.5.3 because it's probably a useful feature.

smitelij commented 6 years ago

Hi, I should be able to get around to resolving conflicts this weekend. Thank you for your patience.

Eli

On Fri, Mar 2, 2018, 2:40 AM Ali Torabi notifications@github.com wrote:

Conflicts on this pull request are getting higher and higher. Please fix them and then we can publish this on version 1.5.3 because it's probably a useful feature.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/owsolutions/amazing-time-picker/pull/57#issuecomment-369846190, or mute the thread https://github.com/notifications/unsubscribe-auth/ACg_JbJojStI6SZ1M483D2x-vOZq2rkDks5taPd5gaJpZM4SJvfd .

torabian commented 6 years ago

Thank you so much.

smitelij commented 6 years ago

Should be good now, sorry for the delay. Let me know if you have any concerns

torabian commented 6 years ago

Thank you for this contribution. It will be available from 1.6.0 onward on npm.