search

owsolutions / amazing-time-picker

Timepicker (Clock Picker) for Angular 2, Angular 4 and Angular 5, Angular 6, Angular 7 - Compatible with Angular Material
137 stars 76 forks source link

rxjs Subject #90

Closed wonez closed 6 years ago

wonez commented 6 years ago

Webpack does not allow app to be compiled stating

Can't resolve 'rxjs/Subject'

I had to change in /node_modules/amazing-time-picker.js import { Subject as Subject$1 } from 'rxjs/Subject'; with import { Subject as Subject$1 } from 'rxjs';

Chris2011 commented 6 years ago

I have the same problem. Maybe you can create a PR.

torabian commented 6 years ago

@Chris2011 I've merged your pr. Is this issue solved by that?

Chris2011 commented 6 years ago

I didn't do a PR, but yes, removing Subject and Rx from rxjs/* is resolving the issue. Can't see any sideeffects after using it.

Chris2011 commented 6 years ago

rxjs-compat is not needed.

ndraiman commented 6 years ago

Which version has the fix? i'm not seeing this in my project.

Getting Module not found: Error: Can't resolve 'rxjs/Subject' if i remove rxjs-compat. The fix should be to import Subject directly from rxjs:

import { Subject} from 'rxjs';
DrMabuse23 commented 6 years ago

yes need it to

torabian commented 6 years ago

Please download version 1.8.0. We addressed this issue.