owx0130 / pe

0 stars 0 forks source link

uninformative error message for phone number #10

Open owx0130 opened 3 months ago

owx0130 commented 3 months ago

image.png

error message here says "wrong number format" even though a number was inputted. the user gets the same error if a garbage string was inputted instead:

image.png

this is not very informative to the user on the exact issue with their input

nus-se-script commented 2 months ago

Team's Response

As seen in the UG:

image.png

The number of classes attended must be below 500. For the first case, the default error message has been printed due to an integer overflow. In the second case, the error message is rather fitting, as the user had typed a non-integer type value into the field. Moreover, an example of what is considered a proper input format is shown clearly in the error message printed.

Lastly, it should not be difficult to put 2 and 2 together when having to put an integer into that field for the input to be accepted, especially when accompanied by the UG and the error message present.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]