owx0130 / pe

0 stars 0 forks source link

application allows editing to the same value #14

Open owx0130 opened 3 months ago

owx0130 commented 3 months ago

image.png

the application allows editing a field to the exact same value it was before, which does not make much sense. in this case phone number is edited, but other fields face the same issue

soc-pe-bot commented 2 months ago

Team's Response

This is of the expected behaviour that our program should output in this use case. Since the original value of the phone number is already valid, it is by design choice to allow the user to reinput the same phone number when trying to edit it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: i would first like to reclassify the bug type as a feature flaw, as I believe i had made a mistake in identifying it previously.

the team mentioned that it was their design choice to allow users to edit to the same value in the edit feature, which I believe could have been implemented better. the purpose of an edit feature is to change to another value, thus allowing users to change back to the same value does not make much semantical sense and also decreases the robustness of the feature in my opinion.

i feel that making this enhancement to disallow editing to the same value would be rather straightforward to implement, and also improve the edit feature's robustness.

as such, i feel like this feature flaw should be considered valid with a severity level of low