search

owx0130 / pe

0 stars 0 forks source link

unclear sequence diagram in Student Details #27

Open owx0130 opened 3 months ago

owx0130 commented 3 months ago

image.png

it is not immediately clear to the reader what exactly the N variable here is referring to.

nus-pe-bot commented 2 months ago

Team's Response

The convention for N is correct as per the Java Guidelines, for the size of an array. Moreover, it is shown in the same screenshot as to what N is referring to. Using a longer name for N would have made the diagram more unreadable.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]