search

owx0130 / pe

0 stars 0 forks source link

no error messages printed when corrupt date is given #6

Open owx0130 opened 3 months ago

owx0130 commented 3 months ago

image.png

if user edits the data file as such (corrupt date), performing view in the application will default the last payment date to today's date without informing the user. This is contrary to what the FAQ mentioned:

image.png

here is the output:

image.png

soc-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

no error handling of dates later than today

image.png

if user manually edits the data file as such, i.e. changing last payment date to a future date, the application runs as per normal:

image.png

[original: nus-cs2113-AY2324S2/pe-interim#89] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We have mentioned not to edit the save file in the user guide. Any data input by the user through editing the save files is thus up to their own onus.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: i disagree that this is a duplicate issue as the original bug and this bug addresses two different concerns. The original bug addresses providing a valid date input, albeit later than today, but this issue addresses providing an invalid date input (i.e. garbage values).

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** the TP constraints outlined that the text file should be editable: ![image.png](https://raw.githubusercontent.com/owx0130/pe/main/files/5b01c0d2-f700-47d3-a5b4-e4e843d7fb2e.png) since the constraints also specified that users that type fast should be targeted, it is also possible that they might accidentally omit some values while editing the data file i.e. `2024-09-0`, making it a garbage input. as in the bug description, the application should inform the user that it has defaulted the last payment date to today or inform the user to enter a new date when relaunched. therefore, i believe that this functionality bug should be valid with severity level of low