search

ox-it / OxfordIDN_htmlwidgets

Interactive visualisation templates with htmlwidgets and R
http://ox-it.github.io/OxfordIDN_htmlwidgets/
MIT License
3 stars 6 forks source link

Code fragments need comments #2

Closed ToonTalk closed 7 years ago

ToonTalk commented 8 years ago

But not too many. E.g. in http://ox-it.github.io/LiveData_htmlwidgets/charts/BarCharts/ there is

desktopItems <- read.csv(file = "https://ndownloader.figshare.com/files/5360960") knitr::kable(head(desktopItems))

I think the first line is self-evident so I recommend changing it to

desktopItems <- read.csv(file = "https://ndownloader.figshare.com/files/5360960") // after reading the CSV file blah blah blah ... knitr::kable(head(desktopItems))

charliejhadley commented 7 years ago

The initial concern has been addressed, regarding kable. https://github.com/ox-it/OxfordIDN_htmlwidgets/issues/45