search

ox-it / OxfordIDN_htmlwidgets

Interactive visualisation templates with htmlwidgets and R
http://ox-it.github.io/OxfordIDN_htmlwidgets/
MIT License
3 stars 6 forks source link

stacked_bar_chart should add a comment to the default ordering_function #32

Closed ToonTalk closed 8 years ago

ToonTalk commented 8 years ago

Later you do explain the c leaves the order unchanged but I think there should also be a comment about this in the function definition itself.

Also in the example application where ordering_function = var do nearly all readers know that 'var' is the variance function? If not another comment would help.

charliejhadley commented 8 years ago

Comment should be added, agreed

charliejhadley commented 8 years ago

Already fixed, don't have commit reference - though.