search

ox-it / munki-rebrand

Script to rebrand Munki's Managed Software Center
BSD 3-Clause "New" or "Revised" License
89 stars 24 forks source link

initial munki3 support #14

Closed erikng closed 7 years ago

erikng commented 7 years ago

This PR gives initial support for munki3.

I haven't tested what happens when running this on a munki2 code repo.

I wanted to get this up and then have a discussion on next steps.

fuzzylogiq commented 7 years ago

Hey Erik,

I don't think this is necessary and tested this today - munki-notifier just uses the same app name and icon that MSC is using and also there are no mentions of the app name itself in munki-notifier or its localisations.

What I also tested with Greg today was that munki-notifier can launch a rebranded MSC.app if notifications have been ignored for > 3days. The good news is it can since we don't change the name of OSC in the file system. So, currently Munki3 looks good with current munki_rebrand.

erikng commented 7 years ago

Nice. Sounds good.

From: Ben Goodstein notifications@github.com Sent: Thursday, March 16, 2017 9:26:16 AM To: ox-it/munki-rebrand Cc: Erik Gomez; Author Subject: Re: [ox-it/munki-rebrand] initial munki3 support (#14)

Hey Erik,

I don't think this is necessary and tested this today - munki-notifier just uses the same app name and icon that MSC is using and also there are no mentions of the app name itself in munki-notifier or its localisations.

What I also tested with Greg today was that munki-notifier can launch a rebranded MSC.app if notifications have been ignored for > 3days. The good news is it can since we don't change the name of OSC in the file system. So, currently Munki3 looks good with current munki_rebrand.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ox-it/munki-rebrand/pull/14#issuecomment-287112517, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFa_GDxTyKzL6mYqhhu2iaK27Xv_v6ieks5rmWKogaJpZM4Mc73X.