search

ox-it / munki-rebrand

Script to rebrand Munki's Managed Software Center
BSD 3-Clause "New" or "Revised" License
88 stars 24 forks source link

postinstall.sh is not integrated #40

Closed dannykorpan closed 4 years ago

dannykorpan commented 4 years ago

Hi,

I've tried to integrate a postinstall.sh via the p parameter. But after creating the new package with munki_rebrand.py and executing the new package or after extracting the newly created package via pkgutil --expand there is no postinstall in the package inside.

sudo ./munki_rebrand.py -a 'Software Center' -k munkitools-4.0.0.3881.pkg -o youknow -p 'postinstall.sh'

content of postinstall.sh

#!/bin/bash
SETPREF="defaults write /Library/Preferences/ManagedInstalls"
$SETPREF SoftwareRepoURL https://munki.mydomain.com
$SETPREF ClientIdentifier selfservice

Kind Regards

sphen13 commented 4 years ago

Try naming it just postinstall without the .sh

From: Danny Korpan notifications@github.com Date: Tuesday, November 26, 2019 at 9:51 AM To: ox-it/munki-rebrand munki-rebrand@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ox-it/munki-rebrand] postinstall.sh is not integrated (#40)

Hi,

I've tried to integrate a postinstall.sh via the p parameter. But after creating the new package with munki_rebrand.py and executing the new package or after extracting the newly created package via pkgutil --expand there is no postinstall in the package inside.

sudo ./munki_rebrand.py -a 'Software Center' -k munkitools-4.0.0.3881.pkg -o youknow -p 'postinstall.sh'

content of postinstall.sh

!/bin/bash

SETPREF="defaults write /Library/Preferences/ManagedInstalls"

$SETPREF SoftwareRepoURL https://munki.mydomain.com

$SETPREF ClientIdentifier selfservice

Kind Regards

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ox-it/munki-rebrand/issues/40?email_source=notifications&email_token=AAEACP3WEHDU2FNJE7H27UTQVUZXTA5CNFSM4JRZFVC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4EPJBQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEACP3LIY2QVPPE6TFOLZTQVUZXTANCNFSM4JRZFVCQ.

fuzzylogiq commented 4 years ago

The postinstall is in the munkitools_app pkg inside the munkitools metapkg, not the metapkg itself. Where were you looking for it?

dannykorpan commented 4 years ago

It's now working - I don't know why it's not working in the past, because I've nothing changed.