search

ox-it / munki-rebrand

Script to rebrand Munki's Managed Software Center
BSD 3-Clause "New" or "Revised" License
88 stars 24 forks source link

Notarization fails #61

Open sphen13 opened 1 month ago

sphen13 commented 1 month ago

Seems #60 caused a regression in behavior. When i try to use munki-rebrand, signing as usual and then submitting for notarization it fails with a laundry list of issues. reverting to the previous commit fixes the behavior. This is with the latest 6.5.1 munki.

sphen13 commented 1 month ago

here are the apple logs for the failed run (current code) and the successful run (one commit back)

fail: https://gist.github.com/sphen13/40ad3d95ebb029b467cf46627646c041

success: https://gist.github.com/sphen13/b073a9b91caef0cf39899dee510a0094

fuzzylogiq commented 1 month ago

Please can you provide the exact command line you used (you can redact anything sensitive)?

sphen13 commented 1 month ago

sure -

/Users/sphen/src/munki-rebrand/munki_rebrand.py -a "Third Vantage Software Center" -i /path/to/Icon-1024.png -o "/Users/sphen/src/thirdvantage/Munki/ThirdVantageSC_${clientForAgent}" -s "Developer ID Installer: XXX" -S "Developer ID Application: XXX" -p "/Users/sphen/src/thirdvantage/Munki/postinstall_$clientForAgent"

fuzzylogiq commented 1 month ago

Thanks. Can recreate locally. I need to see if I can fix both notarization & @SteveKueng 's issue with mixed signing in Python by experimenting with the signing options. For now, please use the previous release.

sphen13 commented 1 month ago

Tried to help a bit here - thought i would add back deep=True to the signing commands. This resolved a large amount of errors but some remain still specific to entitlements etc. I am unable to duplicate @SteveKueng 's initial issue as when i run my signed version of munki-python, importing modules seems to work fine? so i dont really want to troubleshoot this if i cant duplicate his initial issue.

https://gist.github.com/sphen13/be340516c22451058d29308068001bb6

sphen13 commented 2 weeks ago

this has been resolved in https://github.com/ox-it/munki-rebrand/commit/71223e5ae22e68683541f86d5e45aa2b4d19552e