search

ox-it / ords

Automatically exported from code.google.com/p/ords
0 stars 0 forks source link

Comments on fields are no longer displaying in editing interface #752

Closed MerielP closed 8 years ago

MerielP commented 8 years ago

When a comment is added to a field, a question mark symbol should appear next to the field name in the editing interface (hovering the mouse pointer over this displays the comment). The question mark is no longer there.

Comments on whole tables still seem to be working as they should.

thestoat commented 8 years ago

I assume you mean the database schema editing interface (rather than the data editing interface)? Can you supply a link of where the question mark does appear (table) and an example where it doean't (field name)? I am having problems finding any ...

MerielP commented 8 years ago

No - I mean the data editing interface. We've never had the question mark symbols in the schema designer.

On Dev, there's a project called 'Trial project' which contains a database called 'Example database'. In that, there's a table called 'table with comments'. This has comments on both the table itself, and on all of the fields except the primary key. If you go and view the table in the data editing interface (this is the URL on my screen), you will see the comment ('A table which has comments on both it and the fields in it') at the bottom of the screen, but you will not see any question mark symbols on the field names, despite the fact that the schema designer clearly shows they do have comments.

By contrast, if you go to App, and look at 'Sample project', in the database called 'Victorian Gentlemen's Clubs', in the 'people' table (this is the URL), you will see that the 'occupation' field name has the small question mark symbol next to it.

table with comment symbol

Hovering over this displays the comment.

In the course of investigating this, I've also discovered another problem with comments: if a table contains no records, any comments are not displayed. (One wouldn't expect comments on individual fields to be displayed under these circumstances, but comments on the table should be.)

(I'm bumping the priority of this up from High to Critical, as this is currently working in App but not on Dev, and we don't want to do a new build to App until we're reasonably sure it's not going to break any existing features.)

thestoat commented 8 years ago

Fixed

MerielP commented 8 years ago

Excellent - thanks.

The problem where comments don't display on tables with no records is still there, but I've just checked and that also happens on App, so it doesn't count as critical. I'll close this issue.