Closed dolfinus closed 3 years ago
@alexsdutton Could you please take a look at this PR?
Hi @dolfinus. I can have a look and provide a review, but I no longer work for the University of Oxford IT Services, so someone there would need to merge and release. It might be a week before I get a chance to look at it out of work hours.
I've migrated to requests-kerberos
In some cases an error is raised while trying to determine hostname by IP address:
gethostbyaddr
returns a hostname only if DNS PTR record is properly set. But it can be not set, and this is quite frequent error (https://mail.python.org/pipermail/tutor/2015-July/106010.html, https://lists.isc.org/pipermail/bind-users/2003-October/046673.html). It such a case user will face with an exception.Even if
service_name
(inHTTP@host
format) is already passed, user will still see an exception because hostname is still being checked, but there is no need to do that.In this PR I've made few small changes:
service_name
option was passed