Fix `nil diagnostics` exit code

oxalica / nil

NIx Language server, an incremental analysis assistant for writing in Nix.

Apache License 2.0

1.28k stars 39 forks source link

Closed 9999years closed 3 months ago

9999years commented 6 months ago

nil diagnostics --help states:

Exit with non-zero code if there are any diagnostics. (1 for errors, 2 if only warnings)

In practice, nil would only exit with code 1 if there were errors, and if warnings were present it would exit with code 0.

oxalica commented 3 months ago

Close in favor of #136, whose semantic is more correct to me.

9999years commented 3 months ago

But... I want to fail if there's any warnings. Can we add a --deny-warnings option or similar?